AB random failure: libpcre-native split_and_strip
PATCH 1/1 AB random failure: libpcre-native split_and_strip
Error handling: adding file-native as a dependency to libpre recipe should guarantee a consistent, and more importantly POSIX-compliant version of the "file" command is always used when checking the file "pcre-config" within the isELF function in staging.bbclass.
Following the POSIX behavior, file returns 0 and continues, when an error is found while checking a file.
Debug: in cases where file may still fail, the resulting error will now be logged along with the split_and_strip_files failure.
[YOCTO #8144]
--- meta/classes/staging.bbclass | 2 +- meta/recipes-support/libpcre/libpcre_8.37.bb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
meta/classes/staging.bbclass +1 -1
@@ -77,7 +77,7 @@ python sysroot_strip () { ret, result = oe.utils.getstatusoutput("file \"%s\"" % path.replace("\"", "\\\"")) if ret: - bb.error("split_and_strip_files: 'file %s' failed" % path) + bb.error("split_and_strip_files: 'file %s' failed\nError: %s" % (path, result)) return type # Not stripped
meta/recipes-support/libpcre/libpcre_8.37.bb +1 -1
@@ -20,7 +20,7 @@ SRC_URI[sha256sum] = "51679ea8006ce31379fb0860e46dd86665d864b5020fc9cd19e71260ee S = "${WORKDIR}/pcre-${PV}" PROVIDES += "pcre" -DEPENDS += "bzip2 zlib" +DEPENDS += "bzip2 zlib file-native" PACKAGECONFIG[pcretest-readline] = "--enable-pcretest-libreadline,--disable-pcretest-libreadline,readline,"
Signature · 1 line
2.5.3
Quoted 10 lines · Alex Franco
Error handling: adding file-native as a dependency to libpre recipe should guarantee a consistent, and more importantly POSIX-compliant version of the "file" command is always used when checking the file "pcre-config" within the isELF function in staging.bbclass.
Following the POSIX behavior, file returns 0 and continues, when an error is found while checking a file.
Debug: in cases where file may still fail, the resulting error will now be logged along with the
split_and_strip_filesfailure.
I like the improvement in debug, I'm not sure the other part of this will solve the problem though. We've seen this error on recipes other that libpcre and also, which systems do you think doesn't have a POSIX-compliant version of the file?
Cheers,
Richard
Quoted 37 lines
[YOCTO #8144]
Signed-off-by Alex Franco <[email protected]>--- meta/classes/staging.bbclass | 2 +- meta/recipes-support/libpcre/libpcre_8.37.bb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)meta/classes/staging.bbclass +1
-1@@ -77,7 +77,7 @@ python sysroot_strip () { ret, result = oe.utils.getstatusoutput("file \"%s\"" % path.replace("\"", "\\\"")) if ret: - bb.error("split_and_strip_files: 'file %s' failed" % path) + bb.error("split_and_strip_files: 'file %s' failed\nError: %s" % (path, result)) return type # Not strippedmeta/recipes-support/libpcre/libpcre_8.37.bb +1
-1@@ -20,7 +20,7 @@ SRC_URI[sha256sum] = "51679ea8006ce31379fb0860e46dd86665d864b5020fc9cd19e71260ee S = "${WORKDIR}/pcre-${PV}" PROVIDES += "pcre" -DEPENDS += "bzip2 zlib" +DEPENDS += "bzip2 zlib file-native" PACKAGECONFIG[pcretest-readline] = "--enable-pcretest-libreadline,--disable-pcretest-libreadline,readline,"Signature · 1 line
2.5.3