Patch "IB/uverbs: reject invalid or unknown opcodes" has been added to the 3.10-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
IB/uverbs: reject invalid or unknown opcodes
to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ib-uverbs-reject-invalid-or-unknown-opcodes.patch
and it can be found in the queue-3.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
b632ffa7cee439ba5dce3b3bc4a5cbe2b3e20133Mon Sep 17 00:00:00 2001
From: Christoph Hellwig <[email protected]>
Date: Wed, 26 Aug 2015 11:00:37 +0200
Subject: IB/uverbs: reject invalid or unknown opcodes
From: Christoph Hellwig <[email protected]>
commit b632ffa7cee439ba5dce3b3bc4a5cbe2b3e20133 upstream.
We have many WR opcodes that are only supported in kernel space and/or require optional information to be copied into the WR structure. Reject all those not explicitly handled so that we can't pass invalid information to drivers.
--- drivers/infiniband/core/uverbs_cmd.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/infiniband/core/uverbs_cmd.c +9 -1
@@ -2106,6 +2106,12 @@ ssize_t ib_uverbs_post_send(struct ib_uv next->send_flags = user_wr->send_flags;if (is_ud) { +if (next->opcode !=IB_WR_SEND && + next->opcode !=IB_WR_SEND_WITH_IMM ) { + ret = -EINVAL ; + goto out_put; + } + next->wr.ud.ah =idr_read_ah (user_wr->wr.ud.ah, file->ucontext);if (!next->wr.ud.ah) {
@@ -2142,9 +2148,11 @@ ssize_t ib_uverbs_post_send(struct ib_uv user_wr->wr.atomic.compare_add; next->wr.atomic.swap = user_wr->wr.atomic.swap; next->wr.atomic.rkey = user_wr->wr.atomic.rkey; +case IB_WR_SEND :break ;default : -break ; + ret = -EINVAL ; + goto out_put; } }
Patches currently in stable-queue which might be from [email protected] are
queue-3.10/ib-uverbs-reject-invalid-or-unknown-opcodes.patch