pc: Add a comment explaining why pc_compat_2_4() doesn't exist
PATCH 1/1 pc: Add a comment explaining why pc_compat_2_4() doesn't exist
pc_compat_2_4() doesn't exist, and we shouldn't create one. Add a comment explaining why the function doesn't exist and why pc_compat_*() functions are deprecated.
Signed-off-by Eduardo Habkost <[email protected]>
--- hw/i386/pc_piix.c | 7 +++++++ hw/i386/pc_q35.c | 7 +++++++ 2 files changed, 14 insertions(+)
hw/i386/pc_piix.c +7 -0
@@ -301,6 +301,13 @@ static void pc_init1(MachineState *machine, } } +/* Looking for a pc_compat_2_4() function? It doesn't exist. +* pc_compat_*() functions that run on machine-init time and +* change global QEMU state are deprecated. Please don't create +* one, and implement any pc-*-2.4 (and newer) compat code in +* HW_COMPAT_*, PC_COMPAT_*, or * pc_*_machine_options(). +*/ +static void pc_compat_2_3 (MachineState *machine) {PCMachineState *pcms =PC_MACHINE (machine);
hw/i386/pc_q35.c +7 -0
@@ -284,6 +284,13 @@ static void pc_q35_init(MachineState *machine) } } +/* Looking for a pc_compat_2_4() function? It doesn't exist. +* pc_compat_*() functions that run on machine-init time and +* change global QEMU state are deprecated. Please don't create +* one, and implement any pc-*-2.4 (and newer) compat code in +* HW_COMPAT_*, PC_COMPAT_*, or * pc_*_machine_options(). +*/ +static void pc_compat_2_3 (MachineState *machine) {PCMachineState *pcms =PC_MACHINE (machine);
Signature · 1 line
2.1.0