Skip to contentSkip to conversation

gstreamer-omx: Improve variable expansion of ${S}

PATCH New Richard Purdie 1 participant 1 message Sep 30, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gstreamer-omx: Improve variable expansion of ${S}

The way ${S} is expanded into CFLAGS means the recipe is marked as depending on the path within which its built. We can avoid this by avoiding the expansion which then allows reuse of the recipe from sstate.

meta/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc +1 -2
index 8c273fc..6806455 100644
@@ -20,11 +20,10 @@ EXTRA_OECONF += "--disable-valgrind --with-omx-target=${GSTREAMER_1_0_OMX_TARGET
 python __anonymous () {
     omx_target = d.getVar("GSTREAMER_1_0_OMX_TARGET", True)
     if omx_target in ['generic', 'bellagio']:
-        srcdir = d.getVar("S", True)
         # Bellagio headers are incomplete (they are missing the OMX_VERSION_MAJOR,#
         # OMX_VERSION_MINOR, OMX_VERSION_REVISION, and OMX_VERSION_STEP macros);
         # appending a directory path to gst-omx' internal OpenMAX IL headers fixes this
-        d.appendVar("CFLAGS", " -I%s/omx/openmax" % srcdir)
+        d.appendVar("CFLAGS", " -I${S}/omx/openmax")
     elif omx_target == "rpi":
         # Dedicated Raspberry Pi OpenMAX IL support makes this package machine specific
         d.setVar("PACKAGE_ARCH", d.getVar("MACHINE_ARCH", True))