Skip to contentSkip to conversation

toaster: fix broken test case

PATCH In review Ed Bartosh 2 participants 3 messages Sep 30, 2015 – Oct 1, 2015

lore
Share & tools
lore

Ed Bartosh

author
#0 lore raw

PATCH 1/1 toaster: fix broken test case

Fixed test_show_tasks_in_projectbuilds broken by latest changes in project build view.

---
 bitbake/lib/toaster/toastergui/tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/toaster/toastergui/tests.py +1 -1
index 5d15ac9..95790a2 100644
@@ -564,7 +564,7 @@ class ProjectBuildsDisplayTest(TestCase):
         url = reverse("projectbuilds", args=(self.project1.id,))
         response = self.client.get(url, follow=True)
         result = re.findall('^ +bash:clean$', response.content, re.MULTILINE)
-        self.assertEqual(len(result), 1)
+        self.assertEqual(len(result), 2)
 
     def test_show_tasks_in_allbuilds(self):
         build = Build.objects.create(**self.project1_build_success)
Signature · 1 line
2.1.4
#1 lore raw
Quoted 22 lines · Ed Bartosh

Fixed test_show_tasks_in_projectbuilds broken by latest changes in project build view.

---
 bitbake/lib/toaster/toastergui/tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/toaster/toastergui/tests.py +1 -1
index 5d15ac9..95790a2 100644
@@ -564,7 +564,7 @@ class ProjectBuildsDisplayTest(TestCase):
         url = reverse("projectbuilds", args=(self.project1.id,))
         response = self.client.get(url, follow=True)
         result = re.findall('^ +bash:clean$', response.content,
 re.MULTILINE)
-        self.assertEqual(len(result), 1)
+        self.assertEqual(len(result), 2)
 
     def test_show_tasks_in_allbuilds(self):
Quoted 2 lines

build = Build.objects.create(**self.project1_build_success)

I noticed this one, too. I'll submit it to bitbake-devel.

Elliot

Quoted 9 lines

--
2.1.4

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

Signature · 3 lines
Elliot Smith
Software Engineer
Intel Open Source Technology Centre
#2 lore raw

Sent upstream, will add to toaster-next.

Elliot

Quoted 51 lines · Elliot
Quoted 22 lines · Ed Bartosh

Fixed test_show_tasks_in_projectbuilds broken by latest changes in project build view.

---
 bitbake/lib/toaster/toastergui/tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
bitbake/lib/toaster/toastergui/tests.py +1 -1
index 5d15ac9..95790a2 100644
@@ -564,7 +564,7 @@ class ProjectBuildsDisplayTest(TestCase):
         url = reverse("projectbuilds", args=(self.project1.id,))
         response = self.client.get(url, follow=True)
         result = re.findall('^ +bash:clean$', response.content,
 re.MULTILINE)
-        self.assertEqual(len(result), 1)
+        self.assertEqual(len(result), 2)
 
     def test_show_tasks_in_allbuilds(self):
Quoted 2 lines

build = Build.objects.create(**self.project1_build_success)

I noticed this one, too. I'll submit it to bitbake-devel.

Elliot

Quoted 9 lines

--
2.1.4

--
_______________________________________________
toaster mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/toaster

--
Elliot Smith
Software Engineer
Intel Open Source Technology Centre

Signature · 3 lines
Elliot Smith
Software Engineer
Intel Open Source Technology Centre