drm/i915/guc: Don't forward flip interrupts to GuC
Subsystems (2)
PATCH 1/1 drm/i915/guc: Don't forward flip interrupts to GuC
From: Sagar Arun Kamble <[email protected]>
Due to flip interrupts GuC stays awake always and GT does not enter RC6. Do not route those interrupts to GuC for now. Driver won't touch DE_GUCRMR register and leave it as what default value.
--- drivers/gpu/drm/i915/intel_guc_loader.c | 10 ---------- 1 file changed, 10 deletions(-)
drivers/gpu/drm/i915/intel_guc_loader.c +0 -10
@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send nothing to GuC */ -I915_WRITE (DE_GUCRMR , ~0 ); -/* route all GT interrupts to the host */ I915_WRITE (GUC_BCS_RCS_IER ,0 );I915_WRITE (GUC_VCS2_VCS1_IER ,0 );
@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send (all) flip_done to GuC */ - irqs =DERRMR_PIPEA_PRI_FLIP_DONE |DERRMR_PIPEA_SPR_FLIP_DONE | -DERRMR_PIPEB_PRI_FLIP_DONE |DERRMR_PIPEB_SPR_FLIP_DONE | -DERRMR_PIPEC_PRI_FLIP_DONE |DERRMR_PIPEC_SPR_FLIP_DONE ; -/* Unmasked bits will cause GuC response message to be sent */ -I915_WRITE (DE_GUCRMR , ~irqs); -/* route USER_INTERRUPT to Host, all others are sent to GuC. */ irqs =GT_RENDER_USER_INTERRUPT <<GEN8_RCS_IRQ_SHIFT |GT_RENDER_USER_INTERRUPT <<GEN8_BCS_IRQ_SHIFT ;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · On Wed, Sep 30, 2015 at 09:57:37AM -0700, [email protected] wrote:
From: Sagar Arun Kamble <[email protected]>
Due to flip interrupts GuC stays awake always and GT does not enter RC6. Do not route those interrupts to GuC for now. Driver won't touch
DE_GUCRMRregister and leave it as what default value.Signed-off-by Sagar Arun Kamble <[email protected]>Signed-off-by Alex Dai <[email protected]>
[TOR:] This patch was previously sent. Still looks good to me.
Quoted 39 lines
--- drivers/gpu/drm/i915/intel_guc_loader.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/i915/intel_guc_loader.c +0
-10@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send nothing to GuC */ -I915_WRITE (DE_GUCRMR , ~0 ); -/* route all GT interrupts to the host */ I915_WRITE (GUC_BCS_RCS_IER ,0 );I915_WRITE (GUC_VCS2_VCS1_IER ,0 );@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send (all) flip_done to GuC */ - irqs =DERRMR_PIPEA_PRI_FLIP_DONE |DERRMR_PIPEA_SPR_FLIP_DONE | -DERRMR_PIPEB_PRI_FLIP_DONE |DERRMR_PIPEB_SPR_FLIP_DONE | -DERRMR_PIPEC_PRI_FLIP_DONE |DERRMR_PIPEC_SPR_FLIP_DONE ; -/* Unmasked bits will cause GuC response message to be sent */ -I915_WRITE (DE_GUCRMR , ~irqs); -/* route USER_INTERRUPT to Host, all others are sent to GuC. */ irqs =GT_RENDER_USER_INTERRUPT <<GEN8_RCS_IRQ_SHIFT |GT_RENDER_USER_INTERRUPT <<GEN8_BCS_IRQ_SHIFT ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter
AppliedQuoted 10 lines · Tom
Quoted 8 lines · On Wed, Sep 30, 2015 at 09:57:37AM -0700, [email protected] wrote:
From: Sagar Arun Kamble <[email protected]>
Due to flip interrupts GuC stays awake always and GT does not enter RC6. Do not route those interrupts to GuC for now. Driver won't touch
DE_GUCRMRregister and leave it as what default value.Signed-off-by Sagar Arun Kamble <[email protected]>Signed-off-by Alex Dai <[email protected]>[TOR:] This patch was previously sent. Still looks good to me.
Yeah when resending reviewed patches please include the r-b tag to avoid wasting people's time.
Quoted 2 lines
Reviewed-by Tom O'Rourke <Tom.O'[email protected]>
Queued for -next, thanks for the patch.
-Daniel
Quoted 44 lines
Quoted 40 lines
--- drivers/gpu/drm/i915/intel_guc_loader.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/i915/intel_guc_loader.c +0
-10@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send nothing to GuC */ -I915_WRITE (DE_GUCRMR , ~0 ); -/* route all GT interrupts to the host */ I915_WRITE (GUC_BCS_RCS_IER ,0 );I915_WRITE (GUC_VCS2_VCS1_IER ,0 );@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send (all) flip_done to GuC */ - irqs =DERRMR_PIPEA_PRI_FLIP_DONE |DERRMR_PIPEA_SPR_FLIP_DONE | -DERRMR_PIPEB_PRI_FLIP_DONE |DERRMR_PIPEB_SPR_FLIP_DONE | -DERRMR_PIPEC_PRI_FLIP_DONE |DERRMR_PIPEC_SPR_FLIP_DONE ; -/* Unmasked bits will cause GuC response message to be sent */ -I915_WRITE (DE_GUCRMR , ~irqs); -/* route USER_INTERRUPT to Host, all others are sent to GuC. */ irqs =GT_RENDER_USER_INTERRUPT <<GEN8_RCS_IRQ_SHIFT |GT_RENDER_USER_INTERRUPT <<GEN8_BCS_IRQ_SHIFT ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 10 lines · Daniel Vetter
Quoted 9 lines · Tom
Quoted 8 lines · On Wed, Sep 30, 2015 at 09:57:37AM -0700, [email protected] wrote:
From: Sagar Arun Kamble <[email protected]>
Due to flip interrupts GuC stays awake always and GT does not enter RC6. Do not route those interrupts to GuC for now. Driver won't touch
DE_GUCRMRregister and leave it as what default value.Signed-off-by Sagar Arun Kamble <[email protected]>Signed-off-by Alex Dai <[email protected]>
Quoted 8 lines
Quoted 1 line
[TOR:] This patch was previously sent. Still looks good to me.
Yeah when resending reviewed patches please include the r-b tag to avoid wasting people's time.
Quoted 2 lines
Reviewed-by Tom O'Rourke <Tom.O'[email protected]>Queued for -next, thanks for the patch.
Hmm, what's the impact on skl rc6 in v4.3?
BR,
Jani.
Quoted 55 lines
-Daniel
Quoted 44 lines
Quoted 40 lines
--- drivers/gpu/drm/i915/intel_guc_loader.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/i915/intel_guc_loader.c +0
-10@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send nothing to GuC */ -I915_WRITE (DE_GUCRMR , ~0 ); -/* route all GT interrupts to the host */ I915_WRITE (GUC_BCS_RCS_IER ,0 );I915_WRITE (GUC_VCS2_VCS1_IER ,0 );@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send (all) flip_done to GuC */ - irqs =DERRMR_PIPEA_PRI_FLIP_DONE |DERRMR_PIPEA_SPR_FLIP_DONE | -DERRMR_PIPEB_PRI_FLIP_DONE |DERRMR_PIPEB_SPR_FLIP_DONE | -DERRMR_PIPEC_PRI_FLIP_DONE |DERRMR_PIPEC_SPR_FLIP_DONE ; -/* Unmasked bits will cause GuC response message to be sent */ -I915_WRITE (DE_GUCRMR , ~irqs); -/* route USER_INTERRUPT to Host, all others are sent to GuC. */ irqs =GT_RENDER_USER_INTERRUPT <<GEN8_RCS_IRQ_SHIFT |GT_RENDER_USER_INTERRUPT <<GEN8_BCS_IRQ_SHIFT ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Jani Nikula
Quoted 12 lines · Daniel Vetter
Quoted 10 lines · Tom
Quoted 8 lines · On Wed, Sep 30, 2015 at 09:57:37AM -0700, [email protected] wrote:
From: Sagar Arun Kamble <[email protected]>
Due to flip interrupts GuC stays awake always and GT does not enter RC6. Do not route those interrupts to GuC for now. Driver won't touch
DE_GUCRMRregister and leave it as what default value.Signed-off-by Sagar Arun Kamble <[email protected]>Signed-off-by Alex Dai <[email protected]>[TOR:] This patch was previously sent. Still looks good to me.
Quoted 8 lines
Quoted 6 lines
Yeah when resending reviewed patches please include the r-b tag to avoid wasting people's time.
Quoted 2 lines
Reviewed-by Tom O'Rourke <Tom.O'[email protected]>Queued for -next, thanks for the patch.
Hmm, what's the impact on skl rc6 in v4.3?
guc isn't enabled yet anywhere by default. Impact is none. Yup commit message should probably mention that ...
-Daniel
Quoted 64 lines
BR,
Jani.Quoted 55 lines
-Daniel
Quoted 44 lines
Quoted 40 lines
--- drivers/gpu/drm/i915/intel_guc_loader.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/i915/intel_guc_loader.c +0
-10@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send nothing to GuC */ -I915_WRITE (DE_GUCRMR , ~0 ); -/* route all GT interrupts to the host */ I915_WRITE (GUC_BCS_RCS_IER ,0 );I915_WRITE (GUC_VCS2_VCS1_IER ,0 );@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send (all) flip_done to GuC */ - irqs =DERRMR_PIPEA_PRI_FLIP_DONE |DERRMR_PIPEA_SPR_FLIP_DONE | -DERRMR_PIPEB_PRI_FLIP_DONE |DERRMR_PIPEB_SPR_FLIP_DONE | -DERRMR_PIPEC_PRI_FLIP_DONE |DERRMR_PIPEC_SPR_FLIP_DONE ; -/* Unmasked bits will cause GuC response message to be sent */ -I915_WRITE (DE_GUCRMR , ~irqs); -/* route USER_INTERRUPT to Host, all others are sent to GuC. */ irqs =GT_RENDER_USER_INTERRUPT <<GEN8_RCS_IRQ_SHIFT |GT_RENDER_USER_INTERRUPT <<GEN8_BCS_IRQ_SHIFT ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 1 line
Jani Nikula, Intel Open Source Technology Center
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Jani Nikula
Quoted 8 lines · Daniel Vetter
Quoted 7 lines · Tom
Quoted 6 lines · On Wed, Sep 30, 2015 at 09:57:37AM -0700, [email protected] wrote:
From: Sagar Arun Kamble <[email protected]>
Due to flip interrupts GuC stays awake always and GT does not enter RC6. Do not route those interrupts to GuC for now. Driver won't touch
DE_GUCRMRregister and leave it as what default value.
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Signed-off-by Sagar Arun Kamble <[email protected]>Signed-off-by Alex Dai <[email protected]>[TOR:] This patch was previously sent. Still looks good to me.
Yeah when resending reviewed patches please include the r-b tag to avoid wasting people's time.
Quoted 1 line
Reviewed-by Tom O'Rourke <Tom.O'[email protected]>Queued for -next, thanks for the patch.
Hmm, what's the impact on skl rc6 in v4.3?
This change was prepared with v4.3 firmware.
Even with GuC v4.3 firmware, SKL RC6 does not work if flip interrupts are routed to GuC.
Quoted 59 lines
BR,
Jani.Quoted 53 lines
-Daniel
Quoted 43 lines
Quoted 39 lines
--- drivers/gpu/drm/i915/intel_guc_loader.c | 10 ---------- 1 file changed, 10 deletions(-)drivers/gpu/drm/i915/intel_guc_loader.c +0
-10@@ -90,9 +90,6 @@ static void direct_interrupts_to_host(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send nothing to GuC */ -I915_WRITE (DE_GUCRMR , ~0 ); -/* route all GT interrupts to the host */ I915_WRITE (GUC_BCS_RCS_IER ,0 );I915_WRITE (GUC_VCS2_VCS1_IER ,0 );@@ -110,13 +107,6 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv)for_each_ring (ring, dev_priv, i)I915_WRITE (RING_MODE_GEN7 (ring), irqs); -/* tell DE to send (all) flip_done to GuC */ - irqs =DERRMR_PIPEA_PRI_FLIP_DONE |DERRMR_PIPEA_SPR_FLIP_DONE | -DERRMR_PIPEB_PRI_FLIP_DONE |DERRMR_PIPEB_SPR_FLIP_DONE | -DERRMR_PIPEC_PRI_FLIP_DONE |DERRMR_PIPEC_SPR_FLIP_DONE ; -/* Unmasked bits will cause GuC response message to be sent */ -I915_WRITE (DE_GUCRMR , ~irqs); -/* route USER_INTERRUPT to Host, all others are sent to GuC. */ irqs =GT_RENDER_USER_INTERRUPT <<GEN8_RCS_IRQ_SHIFT |GT_RENDER_USER_INTERRUPT <<GEN8_BCS_IRQ_SHIFT ;Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx