Skip to contentSkip to conversation

vme: tsi148: silence uninitialized variable warning

PATCH In review Dmitry Kalinkin 2 participants 3 messages Oct 5, 2015 – Oct 10, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 vme: tsi148: silence uninitialized variable warning

The warning is a false positive.

drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write':
drivers/vme/bridges/vme_tsi148.c:1358:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]

   vme_unregister_error_handler(handler);
                               ^
drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_read':
drivers/vme/bridges/vme_tsi148.c:1260:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]
   vme_unregister_error_handler(handler);
                               ^
Fixes 0b0496625715 ("vme: change bus error handling scheme")
---
 drivers/vme/bridges/vme_tsi148.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/vme/bridges/vme_tsi148.c +2 -2
index d1e383b..6052483 100644
@@ -1186,7 +1186,7 @@ static ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf,
 	int retval, enabled;
 	unsigned long long vme_base, size;
 	u32 aspace, cycle, dwidth;
-	struct vme_error_handler *handler;
+	struct vme_error_handler *handler = NULL;
 	struct vme_bridge *tsi148_bridge;
 	void __iomem *addr = image->kern_base + offset;
 	unsigned int done = 0;
@@ -1276,7 +1276,7 @@ static ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf,
 	unsigned int done = 0;
 	unsigned int count32;
 
-	struct vme_error_handler *handler;
+	struct vme_error_handler *handler = NULL;
 	struct vme_bridge *tsi148_bridge;
 	struct tsi148_driver *bridge;
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 2 lines · Dmitry Kalinkin

The warning is a false positive.

That seems very likely.

Please could you role this into the original patch (vme: change bus error handling scheme)?

Martyn

Quoted 40 lines

drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write':
drivers/vme/bridges/vme_tsi148.c:1358:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]

   vme_unregister_error_handler(handler);
                               ^
drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_read':
drivers/vme/bridges/vme_tsi148.c:1260:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]
   vme_unregister_error_handler(handler);
                               ^
Fixes 0b0496625715 ("vme: change bus error handling scheme")
---
 drivers/vme/bridges/vme_tsi148.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/vme/bridges/vme_tsi148.c +2 -3
index d1e383b..6052483 100644
@@ -1186,7 +1186,7 @@ static ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf,
        int retval, enabled;
        unsigned long long vme_base, size;
        u32 aspace, cycle, dwidth;
-       struct vme_error_handler *handler;
+       struct vme_error_handler *handler = NULL;
        struct vme_bridge *tsi148_bridge;
        void __iomem *addr = image->kern_base + offset;
        unsigned int done = 0;
@@ -1276,7 +1276,7 @@ static ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf,
        unsigned int done = 0;
        unsigned int count32;
 
-       struct vme_error_handler *handler;
+       struct vme_error_handler *handler = NULL;
        struct vme_bridge *tsi148_bridge;
        struct tsi148_driver *bridge;
 
--

1.8.3.1

#2 lore raw

Hi Martyn,

Sorry, your comment is too late. This patch is already in staging-next.

Dmitri

Quoted 53 lines · Martyn Welch
Quoted 2 lines · Dmitry Kalinkin

The warning is a false positive.

That seems very likely.

Please could you role this into the original patch (vme: change bus error handling scheme)?

Martyn

Quoted 40 lines

drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_write':
drivers/vme/bridges/vme_tsi148.c:1358:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]

  vme_unregister_error_handler(handler);
                              ^
drivers/vme/bridges/vme_tsi148.c: In function 'tsi148_master_read':
drivers/vme/bridges/vme_tsi148.c:1260:31: warning: 'handler' may be used uninitialized in this function [-Wmaybe-uninitialized]
  vme_unregister_error_handler(handler);
                              ^
Fixes 0b0496625715 ("vme: change bus error handling scheme")

---
drivers/vme/bridges/vme_tsi148.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)
drivers/vme/bridges/vme_tsi148.c +2 -3
index d1e383b..6052483 100644
@@ -1186,7 +1186,7 @@ static ssize_t tsi148_master_read(struct vme_master_resource *image, void *buf,
       int retval, enabled;
       unsigned long long vme_base, size;
       u32 aspace, cycle, dwidth;
-       struct vme_error_handler *handler;
+       struct vme_error_handler *handler = NULL;
       struct vme_bridge *tsi148_bridge;
       void __iomem *addr = image->kern_base + offset;
       unsigned int done = 0;
@@ -1276,7 +1276,7 @@ static ssize_t tsi148_master_write(struct vme_master_resource *image, void *buf,
       unsigned int done = 0;
       unsigned int count32;
 
-       struct vme_error_handler *handler;
+       struct vme_error_handler *handler = NULL;
       struct vme_bridge *tsi148_bridge;
       struct tsi148_driver *bridge;
 
--

1.8.3.1