Add quirk for Lenovo Yoga 2 with ITE Chips
Subsystems (2)
PATCH 1/1 Add quirk for Lenovo Yoga 2 with ITE Chips
This patch is a follow-up to the one below, send by Guilhem Lettron.
The Lenovo Yoga 2 13 seems to be sold in multiple variants with minor difference3s. IN my case, the USB ID for ITE chip is different than the Yoga 2 11 and Yoga 3 14.
Without the quirk, no data is received from the accelerometer. I have verified the patch, testing this on 4.3-rc4 (and 4.2 stable). With this patch, proper orientation data is received.
rrs@learner:~/Community/UpstreamSources/linux-upstream_GIT (stable-42)$ monitor-sensor
** Message: Accelerometer orientation changed: bottom-up
** Message: Light changed: 0.000000 (lux)
±** Message: Accelerometer orientation changed: left-up
** Message: Accelerometer orientation changed: bottom-up
** Message: Accelerometer orientation changed: left-up
** Message: Accelerometer orientation changed: normal
** Message: Light changed: 29.999999 (lux)
monitor-sensor can be found in the iio-sensor-proxy tool.
commit 47eeca8a4838714e582c2a3058458408a328ed60
Author: Guilhem Lettron <[email protected]> Date: Sat Jun 27 17:02:23 2015 +0200
HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE
Like yogas with TEXAS_INSTRUMENTS, yogas with ITE chips needs to be initialized with enumeration quirks.
--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-sensor-hub.c | 3 +++ 2 files changed, 4 insertions(+)
drivers/hid/hid-ids.h +1 -0
@@ -510,6 +510,7 @@#define USB_VENDOR_ID_ITE 0x048d#define USB_DEVICE_ID_ITE_LENOVO_YOGA 0x8386 +#define USB_DEVICE_ID_ITE_LENOVO_YOGA2 0x8350#define USB_VENDOR_ID_JABRA 0x0b0e#define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412
drivers/hid/hid-sensor-hub.c +3 -0
@@ -777,6 +777,9 @@ static const struct hid_device_id sensor_hub_devices[] = { {HID_DEVICE (HID_BUS_ANY ,HID_GROUP_SENSOR_HUB ,USB_VENDOR_ID_ITE , USB_DEVICE_ID_ITE_LENOVO_YOGA), .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE, + USB_DEVICE_ID_ITE_LENOVO_YOGA2), + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID, HID_ANY_ID) }, { }
Signature · 1 line
2.6.0
Quoted 28 lines · Ritesh Raj Sarraf
This patch is a follow-up to the one below, send by Guilhem Lettron.
The Lenovo Yoga 2 13 seems to be sold in multiple variants with minor difference3s. IN my case, the USB ID for ITE chip is different than the Yoga 2 11 and Yoga 3 14.
Without the quirk, no data is received from the accelerometer. I have verified the patch, testing this on 4.3-rc4 (and 4.2 stable). With this patch, proper orientation data is received.
rrs@learner:~/Community/UpstreamSources/linux-upstream_GIT (stable-42)$ monitor-sensor
** Message: Accelerometer orientation changed: bottom-up
** Message: Light changed: 0.000000 (lux)
±** Message: Accelerometer orientation changed: left-up
** Message: Accelerometer orientation changed: bottom-up
** Message: Accelerometer orientation changed: left-up
** Message: Accelerometer orientation changed: normal
** Message: Light changed: 29.999999 (lux)monitor-sensor can be found in the iio-sensor-proxy tool.
commit
47eeca8a4838714e582c2a3058458408a328ed60Author: Guilhem Lettron <[email protected]> Date: Sat Jun 27 17:02:23 2015 +0200HID: sensor-hub: Add in quirk for Lenovo Yogas with ITE
Quoted 7 lines
Like yogas with
TEXAS_INSTRUMENTS, yogas with ITE chips needs to be initialized with enumeration quirks.Signed-off-by Jiri Kosina <[email protected]>Signed-off-by Ritesh Raj Sarraf <[email protected]>
Quoted 31 lines
--- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-sensor-hub.c | 3 +++ 2 files changed, 4 insertions(+)drivers/hid/hid-ids.h +1
-0@@ -510,6 +510,7 @@#define USB_VENDOR_ID_ITE 0x048d#define USB_DEVICE_ID_ITE_LENOVO_YOGA 0x8386 +#define USB_DEVICE_ID_ITE_LENOVO_YOGA2 0x8350#define USB_VENDOR_ID_JABRA 0x0b0e#define USB_DEVICE_ID_JABRA_SPEAK_410 0x0412drivers/hid/hid-sensor-hub.c +3
-0@@ -777,6 +777,9 @@ static const struct hid_device_id sensor_hub_devices[] = { {HID_DEVICE (HID_BUS_ANY ,HID_GROUP_SENSOR_HUB ,USB_VENDOR_ID_ITE , USB_DEVICE_ID_ITE_LENOVO_YOGA), .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_ITE, + USB_DEVICE_ID_ITE_LENOVO_YOGA2), + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK}, { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID, HID_ANY_ID) }, { }
Jiri Kosina
maintainerQuoted 3 lines · Ritesh Raj Sarraf
The Lenovo Yoga 2 13 seems to be sold in multiple variants with minor difference3s. IN my case, the USB ID for ITE chip is different than the Yoga 2 11 and Yoga 3 14.
I've changed the changelog/subject formatting a little bit and applied to hid.git#for-4.3/upstream-fixes (please note that this doesn't guarantee that this patch will not go to 4.3 still, because it alone is not going to be reason for pull request, but might eventually piggy-back on something that'll be needed for 4.3).
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs