Skip to contentSkip to conversation

regmap: change bool to 1 bit variable in struct regmap

RFC Superseded yalin wang 3 participants 5 messages Oct 8, 2015 1 message not in the archive

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

yalin wang

author
#0 lore raw

RFC 1/1 regmap: change bool to 1 bit variable in struct regmap

This patch change some bool variables in struct regmap { } to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap.

---
 drivers/base/regmap/internal.h | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)
drivers/base/regmap/internal.h +10 -11
index 873ddf9..f4a5f7b 100644
@@ -67,7 +67,6 @@ struct regmap {
 	void *bus_context;
 	const char *name;
 
-	bool async;
 	spinlock_t async_lock;
 	wait_queue_head_t async_waitq;
 	struct list_head async_list;
@@ -99,7 +98,16 @@ struct regmap {
 	int (*reg_read)(void *context, unsigned int reg, unsigned int *val);
 	int (*reg_write)(void *context, unsigned int reg, unsigned int val);
 
-	bool defer_caching;
+	u8 async : 1,
+	defer_caching : 1,
+	/* if set, remember to free reg_defaults_raw */
+	cache_free : 1,
+	/* if set, the HW registers are known to match map->reg_defaults */
+	no_sync_defaults : 1,
+	/* if set, converts bulk rw to single rw */
+	use_single_rw : 1,
+	/* if set, the device supports multi write mode */
+	can_multi_write : 1;
 
 	u8 read_flag_mask;
 	u8 write_flag_mask;
@@ -125,25 +133,16 @@ struct regmap {
 	u32 cache_only;
 	/* if set, only the HW is modified not the cache */
 	u32 cache_bypass;
-	/* if set, remember to free reg_defaults_raw */
-	bool cache_free;
 
 	struct reg_default *reg_defaults;
 	const void *reg_defaults_raw;
 	void *cache;
 	/* if set, the cache contains newer data than the HW */
 	u32 cache_dirty;
-	/* if set, the HW registers are known to match map->reg_defaults */
-	bool no_sync_defaults;
 
 	struct reg_sequence *patch;
 	int patch_regs;
 
-	/* if set, converts bulk rw to single rw */
-	bool use_single_rw;
-	/* if set, the device supports multi write mode */
-	bool can_multi_write;
-
 	struct rb_root range_tree;
 	void *selector_work_buf;	/* Scratch buffer used for selector */
 };
Signature · 1 line
1.9.1
maintainer
#1 lore raw

drivers/base/regmap/internal.h struct regmap { · line 101

Quoted 1 line · yalin wang
drivers/base/regmap/internal.h +1 -0
+	u8 async : 1,

Please use the kernel coding style, no spaces around the :.

author
#2 lore raw

ok, i will send V2 patch

Quoted 7 lines · Mark Brown

drivers/base/regmap/internal.h struct regmap { · line 101

Quoted 1 line · yalin wang
drivers/base/regmap/internal.h +1 -0
+	u8 async : 1,

Please use the kernel coding style, no spaces around the :.

A message that is not in the archive (sent off-list or not yet received): [email protected]

maintainer
#4 lore raw
Quoted 2 lines · yalin wang

i also found lots of code use this wrong coding style by search source code :

$ egrep -H ' : [0-9]+' `find . -name *.h`  | grep -v '?'   > ~/result.txt

Mostly old and/or obscure code, or code that's shared with other things.

#5 lore raw
In reply to yalin wang
Quoted 2 lines · yalin wang

This patch change some bool variables in struct regmap { } to be u8 v : 1 type, so that we can shrink the sizeof of struct regmap.

Are there any atomicity/locking implications?