Patch "target: Attach EXTENDED_COPY local I/O descriptors to xcopy_pt_sess" has been added to the 4.2-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
target: Attach EXTENDED_COPY local I/O descriptors to xcopy_pt_sess
to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
target-attach-extended_copy-local-i-o-descriptors-to-xcopy_pt_sess.patch
and it can be found in the queue-4.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
4416f89b8cfcb794d040fc3b68e5fb159b7d8d02Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <[email protected]>
Date: Thu, 3 Sep 2015 06:30:45 +0000
Subject: target: Attach EXTENDED_COPY local I/O descriptors to xcopy_pt_sess
From: Nicholas Bellinger <[email protected]>
commit 4416f89b8cfcb794d040fc3b68e5fb159b7d8d02 upstream.
This patch is a >= v4.1 regression bug-fix where control CDB emulation logic in commit 38b57f82 now expects a se_cmd->se_sess pointer to exist when determining T10-PI support is to be exposed for initiator host ports.
To address this bug, go ahead and add locally generated se_cmd descriptors for copy-offload block-copy to it's own stand-alone se_session nexus, while the parent EXTENDED_COPY se_cmd descriptor remains associated with it's originating se_cmd->se_sess nexus.
Note a valid se_cmd->se_sess is also required for future support of WRITE_INSERT and READ_STRIP software emulation when submitting backend I/O to se_device that exposes T10-PI suport.
--- drivers/target/target_core_xcopy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/target/target_core_xcopy.c +4 -2
@@ -450,6 +450,8 @@ int target_xcopy_setup_pt(void)memset (&xcopy_pt_sess,0 ,sizeof (struct se_session ));INIT_LIST_HEAD (&xcopy_pt_sess.sess_list);INIT_LIST_HEAD (&xcopy_pt_sess.sess_acl_list); +INIT_LIST_HEAD (&xcopy_pt_sess.sess_cmd_list); +spin_lock_init (&xcopy_pt_sess.sess_cmd_lock); xcopy_pt_nacl.se_tpg = &xcopy_pt_tpg; xcopy_pt_nacl.nacl_sess = &xcopy_pt_sess;
@@ -644,7 +646,7 @@ static int target_xcopy_read_source(pr_debug ("XCOPY: Built READ_16: LBA: %llu Sectors: %u Length: %u\n" , (unsigned long long )src_lba, src_sectors, length); -transport_init_se_cmd (se_cmd, &xcopy_pt_tfo,NULL , length, +transport_init_se_cmd (se_cmd, &xcopy_pt_tfo, &xcopy_pt_sess, length,DMA_FROM_DEVICE ,0 , &xpt_cmd->sense_buffer[0 ]); xop->src_pt_cmd = xpt_cmd;
@@ -704,7 +706,7 @@ static int target_xcopy_write_destinatiopr_debug ("XCOPY: Built WRITE_16: LBA: %llu Sectors: %u Length: %u\n" , (unsigned long long )dst_lba, dst_sectors, length); -transport_init_se_cmd (se_cmd, &xcopy_pt_tfo,NULL , length, +transport_init_se_cmd (se_cmd, &xcopy_pt_tfo, &xcopy_pt_sess, length,DMA_TO_DEVICE ,0 , &xpt_cmd->sense_buffer[0 ]); xop->dst_pt_cmd = xpt_cmd;
Patches currently in stable-queue which might be from [email protected] are
queue-4.2/target-iscsi-fix-np_ip-bracket-issue-by-removing-np_ip.patch queue-4.2/iser-target-put-the-reference-on-commands-waiting-for-unsol-data.patch queue-4.2/iser-target-remove-command-with-state-istate_remove.patch queue-4.2/target-attach-extended_copy-local-i-o-descriptors-to-xcopy_pt_sess.patch queue-4.2/target-fix-pr-registration-aptpl-rcu-conversion-regression.patch