Skip to contentSkip to conversation

Patch "blockdev: don't set S_DAX for misaligned partitions" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Oct 13, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

blockdev: don't set S_DAX for misaligned partitions

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
blockdev-don-t-set-s_dax-for-misaligned-partitions.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f0b2e563bc419df7c1b3d2f494574c25125f6aed Mon Sep 17 00:00:00 2001

From: Jeff Moyer <[email protected]>
Date: Fri, 14 Aug 2015 16:15:32 -0400
Subject: blockdev: don't set S_DAX for misaligned partitions

From: Jeff Moyer <[email protected]>

commit f0b2e563bc419df7c1b3d2f494574c25125f6aed upstream.

The dax code doesn't currently support misaligned partitions, so disable O_DIRECT via dax until such time as that support materializes.

---
 fs/block_dev.c |    7 +++++++
 1 file changed, 7 insertions(+)
fs/block_dev.c +7 -0
@@ -1234,6 +1234,13 @@ static int __blkdev_get(struct block_dev
 				goto out_clear;
 			}
 			bd_set_size(bdev, (loff_t)bdev->bd_part->nr_sects << 9);
+			/*
+			 * If the partition is not aligned on a page
+			 * boundary, we can't do dax I/O to it.
+			 */
+			if ((bdev->bd_part->start_sect % (PAGE_SIZE / 512)) ||
+			    (bdev->bd_part->nr_sects % (PAGE_SIZE / 512)))
+				bdev->bd_inode->i_flags &= ~S_DAX;
 		}
 	} else {
 		if (bdev->bd_contains == bdev) {

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/blockdev-don-t-set-s_dax-for-misaligned-partitions.patch