Skip to contentSkip to conversation

EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN

PATCH Applied [email protected] 2 participants 2 messages Oct 14, 2015 – Oct 15, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC, altera: SoCFPGA EDAC should not look for ECC_CORR_EN

From: Dinh Nguyen <[email protected]>

The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling ECC_CORR_EN, when error happens, it is the user's responsibility to perform a full SDRAM scrub.

Remove the check for ECC_CORR_EN.

---
 drivers/edac/altera_edac.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/edac/altera_edac.h +1 -2
index 7b64dc7..7a52585 100644
@@ -30,8 +30,7 @@
 #define CV_CTLCFG_GEN_SB_ERR       0x2000
 #define CV_CTLCFG_GEN_DB_ERR       0x4000
 
-#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN | \
-				   CV_CTLCFG_ECC_CORR_EN)
+#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN)
 
 /* SDRAM Controller Address Width Register */
 #define CV_DRAMADDRW_OFST          0x2C
Signature · 1 line
2.4.5
maintainer Applied
#1 lore raw
Quoted 19 lines · On Wed, Oct 14, 2015 at 06:14:16PM -0500, [email protected] wrote:

From: Dinh Nguyen <[email protected]>

The bootloader may or may not enable the ECC_CORR_EN bit. By not enabling ECC_CORR_EN, when error happens, it is the user's responsibility to perform a full SDRAM scrub.

Remove the check for ECC_CORR_EN.

---
 drivers/edac/altera_edac.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/edac/altera_edac.h +0 -0
index 7b64dc7..7a52585 100644

drivers/edac/altera_edac.h line 36

Quoted 9 lines
drivers/edac/altera_edac.h +1 -2
@@ -30,8 +30,7 @@
 #define CV_CTLCFG_GEN_SB_ERR       0x2000
 #define CV_CTLCFG_GEN_DB_ERR       0x4000
 
-#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN | \
-				   CV_CTLCFG_ECC_CORR_EN)
+#define CV_CTLCFG_ECC_AUTO_EN     (CV_CTLCFG_ECC_EN)
 
 /* SDRAM Controller Address Width Register */
 #define CV_DRAMADDRW_OFST          0x2C

Applied,
thanks.

Signature · 4 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.