Skip to contentSkip to conversation

Decrease log level for peer float message

PATCH In review Lev Stipakov 3 participants 5 messages Oct 15, 2015

lore
Share & tools
lore

Lev Stipakov

author
#0 lore raw

PATCH 1/1 Decrease log level for peer float message

Signed-off-by Lev Stipakov <[email protected]...>
---
 src/openvpn/mudp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/mudp.c +1 -1
index 3aed3a0..9fa9f9e 100644
@@ -79,7 +79,7 @@ multi_get_create_instance_udp (struct multi_context *m, bool *floated)
 	      {
 		/* reset prefix, since here we are not sure peer is the one it claims to be */
 		ungenerate_prefix(mi);
-		msg (D_MULTI_ERRORS, "Untrusted peer %" PRIu32 " wants to float to %s", peer_id,
+		msg (D_MULTI_MEDIUM, "Untrusted peer %" PRIu32 " wants to float to %s", peer_id,
 			mroute_addr_print (&real, &gc));
 	      }
 	    }
Signature · 1 line
1.9.1
#1 lore raw
Quoted 19 lines · Lev Stipakov
Signed-off-by Lev Stipakov <[email protected]...>
---
 src/openvpn/mudp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/mudp.c +0 -0
index 3aed3a0..9fa9f9e 100644
@@ -79,7 +79,7 @@ multi_get_create_instance_udp (struct multi_context
 *m, bool *floated)
 	      {
 		/* reset prefix, since here we are not sure peer is the one

it claims to be */

src/openvpn/mudp.c +0 -1
 		ungenerate_prefix(mi);
-		msg (D_MULTI_ERRORS, "Untrusted peer %" PRIu32 " wants to

float to %s", peer_id,

src/openvpn/mudp.c +1 -0
+		msg (D_MULTI_MEDIUM, "Untrusted peer %" PRIu32 " wants to

float to %s", peer_id,

src/openvpn/mudp.c multi_get_create_instance_udp (struct multi_context *m, bool *floated) · line 85

Quoted 3 lines
src/openvpn/mudp.c +0 -0
 			mroute_addr_print (&real, &gc));
 	      }
 	    }

ACK. No need to log this so often.

-Steffan

author
#2 lore raw

PATCH 1/1 Refine float logging

v2:
* Bump log level for attack attempt message
* More clear message for float event

v1:
* Decrease log level for peer float message

Signed-off-by Lev Stipakov <[email protected]...>
---
 src/openvpn/mudp.c  | 2 +-
 src/openvpn/multi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
src/openvpn/mudp.c +1 -1
index 3aed3a0..ce67206 100644
@@ -79,7 +79,7 @@ multi_get_create_instance_udp (struct multi_context *m, bool *floated)
 	      {
 		/* reset prefix, since here we are not sure peer is the one it claims to be */
 		ungenerate_prefix(mi);
-		msg (D_MULTI_ERRORS, "Untrusted peer %" PRIu32 " wants to float to %s", peer_id,
+		msg (D_MULTI_MEDIUM, "Float requested for peer %" PRIu32 " to %s", peer_id,
 			mroute_addr_print (&real, &gc));
 	      }
 	    }
src/openvpn/multi.c +1 -1
index 05c36db..7c3aaac 100644
@@ -2286,7 +2286,7 @@ void multi_process_float (struct multi_context* m, struct multi_instance* mi)
       /* do not float if target address is taken by client with another cert */
       if (!cert_hash_compare(m1->locked_cert_hash_set, m2->locked_cert_hash_set))
 	{
-	  msg (D_MULTI_MEDIUM, "Disallow float to an address taken by another client %s",
+	  msg (D_MULTI_LOW, "Disallow float to an address taken by another client %s",
 	       multi_instance_string (ex_mi, false, &gc));
 
 	  mi->context.c2.buf.len = 0;
Signature · 1 line
1.9.1
#3 lore raw

Re: [Openvpn-devel] [PATCH] Refine float logging

Quoted 45 lines · Lev Stipakov

v2:
* Bump log level for attack attempt message
* More clear message for float event

v1:
* Decrease log level for peer float message

Signed-off-by Lev Stipakov <[email protected]...>
---
 src/openvpn/mudp.c  | 2 +-
 src/openvpn/multi.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
src/openvpn/mudp.c +0 -0
index 3aed3a0..ce67206 100644
@@ -79,7 +79,7 @@ multi_get_create_instance_udp (struct multi_context
 *m, bool *floated)
 	      {
 		/* reset prefix, since here we are not sure peer is the one

it claims to be */

src/openvpn/mudp.c +0 -1
 		ungenerate_prefix(mi);
-		msg (D_MULTI_ERRORS, "Untrusted peer %" PRIu32 " wants to

float to %s", peer_id,

src/openvpn/mudp.c +1 -0
+		msg (D_MULTI_MEDIUM, "Float requested for peer %" PRIu32 " to

%s", peer_id,

src/openvpn/mudp.c +0 -0
 			mroute_addr_print (&real, &gc));
 	      }
 	    }
src/openvpn/multi.c +0 -0
index 05c36db..7c3aaac 100644
@@ -2286,7 +2286,7 @@ void multi_process_float (struct multi_context* m,
 struct multi_instance* mi)
       /* do not float if target address is taken by client with another

cert */

       if (!cert_hash_compare(m1->locked_cert_hash_set, m2-
Quoted 1 line

locked_cert_hash_set))

src/openvpn/multi.c +0 -1
 	{
-	  msg (D_MULTI_MEDIUM, "Disallow float to an address taken by

another client %s",

src/openvpn/multi.c +1 -0
+	  msg (D_MULTI_LOW, "Disallow float to an address taken by another

client %s",

src/openvpn/multi.c void multi_process_float (struct multi_context* m, struct multi_instance* mi) · line 2292

Quoted 3 lines
src/openvpn/multi.c +0 -0
 	       multi_instance_string (ex_mi, false, &gc));
 
 	  mi->context.c2.buf.len = 0;

Even-more-ACK

-Steffan

#4 lore raw

Re: [Openvpn-devel] [PATCH applied] Refine float logging

In reply to Lev Stipakov

From: David Sommerseth <[email protected]...>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Your patch has been applied to the master branch.

commit 5203d8094f38a9d23d983377171c11b1d3a82ad2

Author: Lev Stipakov
Date:   Thu Oct 15 14:39:42 2015 +0300
     Refine float logging

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: [email protected]...
     URL: http://article.gmane.org/gmane.network.openvpn.devel/10276
     Signed-off-by: David Sommerseth <[email protected]...>

- --
kind regards,

David Sommerseth

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEARECAAYFAlYfvhUACgkQDC186MBRfroFDwCfbG96a12WyLwwvtUXERXnNH5m 5WcAn30rIfWxNfBfkdlxXPmDRvD07+La
=zRPD
-----END PGP SIGNATURE-----