Skip to contentSkip to conversation

mmc_block: Allow more than 8 partitions per card

RFC PATCH Superseded John Stultz 3 participants 5 messages Oct 16, 2015 MMC, SD and SDIO

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 mmc_block: Allow more than 8 partitions per card

From: Colin Cross <[email protected]>

It is quite common for Android devices to utilize more then 8 partitions on internal eMMC storage. This patch, which has been carried for quite awhile in the AOSP common tree is necessary in order to support such configurations, so I wanted to submit it for consideration upstream.

This patch sets the GENHD_FL_EXT_DEVT flag, which will allocate minor number in major 259 for partitions past disk->minors.

It also removes the use of disk_devt to determine devidx from md->disk. md->disk->first_minor is always initialized from devidx and can always be used to recover it.

Thoughts or feedback would be greatly appreciated.

Cc Ulf Hansson <[email protected]>
Cc Adrian Hunter <[email protected]>
Cc Ben Hutchings <[email protected]>
Cc Chuanxiao Dong <[email protected]>
Cc Shawn Lin <[email protected]>
Cc Android Kernel Team <[email protected]>
[jstultz: Added context to commit message]
---
 drivers/mmc/card/block.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
drivers/mmc/card/block.c +2 -5
index c742cfd..564436e 100644
@@ -172,11 +172,7 @@ static struct mmc_blk_data *mmc_blk_get(struct gendisk *disk)
 
 static inline int mmc_get_devidx(struct gendisk *disk)
 {
-	int devmaj = MAJOR(disk_devt(disk));
-	int devidx = MINOR(disk_devt(disk)) / perdev_minors;
-
-	if (!devmaj)
-		devidx = disk->first_minor / perdev_minors;
+	int devidx = disk->first_minor / perdev_minors;
 	return devidx;
 }
 
@@ -2162,6 +2158,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
 	md->disk->queue = md->queue.queue;
 	md->disk->driverfs_dev = parent;
 	set_disk_ro(md->disk, md->read_only || default_ro);
+	md->disk->flags = GENHD_FL_EXT_DEVT;
 	if (area_type & (MMC_BLK_DATA_AREA_RPMB | MMC_BLK_DATA_AREA_BOOT))
 		md->disk->flags |= GENHD_FL_NO_PART_SCAN;
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · John Stultz

From: Colin Cross <[email protected]>

It is quite common for Android devices to utilize more then 8 partitions on internal eMMC storage. This patch, which has been carried for quite awhile in the AOSP common tree is necessary in order to support such configurations, so I wanted to submit it for consideration upstream.

Isn't this what CONFIG_MMC_BLOCK_MINORS is for? It does limit you to 256 minors total, and therefore the number of supported MMC's is equal to 256/CONFIG_MMC_BLOCK_MINORS, but I've never heard of an Android device with support for more than 4 MMC/SD cards (including eMMC's), and I would seriously question anyone who has the need for more than 32 partitions on the root device for a phone/tablet/television.

#2 lore raw
Quoted 9 lines · On Friday 16 October 2015 15:03:29 Austin S Hemmelgarn wrote:
Quoted 7 lines · John Stultz

From: Colin Cross <[email protected]>

It is quite common for Android devices to utilize more then 8 partitions on internal eMMC storage. This patch, which has been carried for quite awhile in the AOSP common tree is necessary in order to support such configurations, so I wanted to submit it for consideration upstream.

Quoted 6 lines

Isn't this what CONFIG_MMC_BLOCK_MINORS is for? It does limit you to 256 minors total, and therefore the number of supported MMC's is equal to 256/CONFIG_MMC_BLOCK_MINORS, but I've never heard of an Android device with support for more than 4 MMC/SD cards (including eMMC's), and I would seriously question anyone who has the need for more than 32 partitions on the root device for a phone/tablet/television.

The 256 minor limit is really arbitrary, we should not be limited by that, and you should have have to decide at compile time whether you might need many partitions or many devices, even if we believe that nobody will ever need both at the same time.

Arnd

#3 lore raw
Quoted 17 lines · Arnd Bergmann
Quoted 9 lines · On Friday 16 October 2015 15:03:29 Austin S Hemmelgarn wrote:
Quoted 7 lines · John Stultz

From: Colin Cross <[email protected]>

It is quite common for Android devices to utilize more then 8 partitions on internal eMMC storage. This patch, which has been carried for quite awhile in the AOSP common tree is necessary in order to support such configurations, so I wanted to submit it for consideration upstream.

Quoted 6 lines

Isn't this what CONFIG_MMC_BLOCK_MINORS is for? It does limit you to 256 minors total, and therefore the number of supported MMC's is equal to 256/CONFIG_MMC_BLOCK_MINORS, but I've never heard of an Android device with support for more than 4 MMC/SD cards (including eMMC's), and I would seriously question anyone who has the need for more than 32 partitions on the root device for a phone/tablet/television.

Quoted 4 lines

The 256 minor limit is really arbitrary, we should not be limited by that, and you should have have to decide at compile time whether you might need many partitions or many devices, even if we believe that nobody will ever need both at the same time.

I didn't mean to imply that I disagree with any of that, I was just trying to get the point across that framing the problem this is trying to solve in such limited terms really isn't the best idea, although I could have gone about doing so in a better way.

#4 lore raw
In reply to Austin S Hemmelgarn
Quoted 10 lines · Austin S Hemmelgarn
Quoted 8 lines · John Stultz

From: Colin Cross <[email protected]>

It is quite common for Android devices to utilize more then 8 partitions on internal eMMC storage. This patch, which has been carried for quite awhile in the AOSP common tree is necessary in order to support such configurations, so I wanted to submit it for consideration upstream.

Quoted 6 lines

Isn't this what CONFIG_MMC_BLOCK_MINORS is for? It does limit you to 256 minors total, and therefore the number of supported MMC's is equal to 256/CONFIG_MMC_BLOCK_MINORS, but I've never heard of an Android device with support for more than 4 MMC/SD cards (including eMMC's), and I would seriously question anyone who has the need for more than 32 partitions on the root device for a phone/tablet/television.

So thanks, CONFIG_MMC_BLOCK_MINORS is something I wasn't aware of, and it does seem to allow me to boot on my device w/o the proposed patch!

That said, my fairly old device does have 30-partitions now, and from Linux Plumber's[1] it seems like Android devices are only going to have more partitions in the future. So as Arnd commented, if the proposed patch provides a less limited solution, it might still be worth consideration. I'll give it a day or so for folks to provide any more commentary, and if no other objections are brought up, I'll re-submit with an improve rational for the patch that includes this info.

Thanks for the feedback!
-john

[1]: https://linuxplumbersconf.org/2015/ocw//system/presentations/3387/original/Android%20system,%20partitions%20and%20customization.pdf