Patch "mmc: sdhci-esdhc-imx: Do not break platform data boards" has been added to the 4.1-stable tree
Subsystems (5)
This is a note to let you know that I've just added the patch titled
mmc: sdhci-esdhc-imx: Do not break platform data boards
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
mmc-sdhci-esdhc-imx-do-not-break-platform-data-boards.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7ccddeb08a632c713eca0a5f13bcbfa7e6e83982Mon Sep 17 00:00:00 2001
From: Fabio Estevam <[email protected]>
Date: Sat, 9 May 2015 09:57:09 -0300
Subject: mmc: sdhci-esdhc-imx: Do not break platform data boards
From: Fabio Estevam <[email protected]>
commit 7ccddeb08a632c713eca0a5f13bcbfa7e6e83982 upstream.
The only user of this driver that has not been converted to fully device tree is the i.MX35 SoC.
There is a i.MX35-based board (mach-pcm043.c) that uses platform data to pass wp_gpio and cd_gpio information.
Commit 8d86e4fcccf61ba ("mmc: sdhci-esdhc-imx: Call mmc_of_parse()") broke the platform data case by removing mmc_gpio_request_ro() and mmc_gpio_request_cd(), so restore the functionality for the non-dt case.
Also, restore the check for ESDHC_CD_CONTROLLER so that we can still support the "fsl,cd-controller" property.
--- drivers/mmc/host/sdhci-esdhc-imx.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-)
drivers/mmc/host/sdhci-esdhc-imx.c +35 -1
@@ -925,6 +925,7 @@ static int sdhci_esdhc_imx_probe(structstruct esdhc_platform_data *boarddata;int err;struct pltfm_imx_data *imx_data; +bool dt = true; host =sdhci_pltfm_init (pdev, &sdhci_esdhc_imx_pdata,0 );if (IS_ERR (host))
@@ -1012,11 +1013,44 @@ static int sdhci_esdhc_imx_probe(struct } imx_data->boarddata = *((struct esdhc_platform_data *) host->mmc->parent->platform_data); + dt = false; + } +/* write_protect */ +if (boarddata->wp_type ==ESDHC_WP_GPIO && !dt) { + err =mmc_gpio_request_ro (host->mmc, boarddata->wp_gpio); +if (err) { +dev_err (mmc_dev (host->mmc), +"failed to request write-protect gpio!\n" ); + goto disable_clk; + } + host->mmc->caps2 |=MMC_CAP2_RO_ACTIVE_HIGH ; }/* card_detect */ -if (boarddata->cd_type ==ESDHC_CD_CONTROLLER ) +switch (boarddata->cd_type) { +case ESDHC_CD_GPIO : +if (dt) +break ; + err =mmc_gpio_request_cd (host->mmc, boarddata->cd_gpio,0 ); +if (err) { +dev_err (mmc_dev (host->mmc), +"failed to request card-detect gpio!\n" ); + goto disable_clk; + } +/* fall through */ + +case ESDHC_CD_CONTROLLER : +/* we have a working card_detect back */ host->quirks &= ~SDHCI_QUIRK_BROKEN_CARD_DETECTION ; +break ; + +case ESDHC_CD_PERMANENT : + host->mmc->caps |=MMC_CAP_NONREMOVABLE ; +break ; + +case ESDHC_CD_NONE : +break ; + }switch (boarddata->max_bus_width) {case 8 :
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/mmc-sdhci-esdhc-imx-do-not-break-platform-data-boards.patch queue-4.1/dts-imx51-fix-sd-card-gpio-polarity-specified-in-device-tree.patch queue-4.1/mmc-sdhci-esdhc-imx-move-mmc_of_parse-to-the-dt-probe.patch queue-4.1/dts-imx6-fix-sd-card-gpio-polarity-specified-in-device-tree.patch queue-4.1/dts-imx25-fix-sd-card-gpio-polarity-specified-in-device-tree.patch queue-4.1/dts-imx53-fix-sd-card-gpio-polarity-specified-in-device-tree.patch queue-4.1/mmc-sdhci-esdhc-imx-fix-cd-regression-for-dt-platform.patch