Skip to contentSkip to conversation

Patch "extcon: Fix signedness bugs about break error handling" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Oct 17, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

extcon: Fix signedness bugs about break error handling

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
extcon-fix-signedness-bugs-about-break-error-handling.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a598af7f0279195abffbfb9bf2070457e9c89ff3 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Tue, 4 Aug 2015 10:47:23 +0300
Subject: extcon: Fix signedness bugs about break error handling

From: Dan Carpenter <[email protected]>

commit a598af7f0279195abffbfb9bf2070457e9c89ff3 upstream.

Unsigned is never less than zero so this error handling won't work.

Fixes be052cc87745 ('extcon: Fix hang and extcon_get/set_cable_state().')
[cw00.choi: Change the patch title and fix signedness bug of find_cable_index_by_id() ]
---
 drivers/extcon/extcon.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/extcon/extcon.c +4 -4
@@ -126,7 +126,7 @@ static int find_cable_index_by_id(struct
 
 static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)
 {
-	unsigned int id = -EINVAL;
+	int id = -EINVAL;
 	int i = 0;
 
 	/* Find the id of extcon cable */
@@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct
 
 static int find_cable_index_by_name(struct extcon_dev *edev, const char *name)
 {
-	unsigned int id;
+	int id;
 
 	if (edev->max_supported == 0)
 		return -EINVAL;
@@ -378,7 +378,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state
  */
 int extcon_get_cable_state(struct extcon_dev *edev, const char *cable_name)
 {
-	unsigned int id;
+	int id;
 
 	id = find_cable_id_by_name(edev, cable_name);
 	if (id < 0)
@@ -426,7 +426,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state
 int extcon_set_cable_state(struct extcon_dev *edev,
 			const char *cable_name, bool cable_state)
 {
-	unsigned int id;
+	int id;
 
 	id = find_cable_id_by_name(edev, cable_name);
 	if (id < 0)

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/hv-util-checking-the-wrong-variable.patch queue-4.2/ath10k-fix-dma_mapping_error-handling.patch queue-4.2/hpsa-fix-an-sprintf-overflow-in-the-reset-handler.patch queue-4.2/extcon-fix-signedness-bugs-about-break-error-handling.patch