Skip to contentSkip to conversation

Patch "usb: phy: phy-generic: Fix reset behaviour on legacy boot" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Oct 17, 2015

Subsystems (2)
Stable branch USB
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

usb: phy: phy-generic: Fix reset behaviour on legacy boot

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
usb-phy-phy-generic-fix-reset-behaviour-on-legacy-boot.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 762982db33b23029e98c844611e2e8beeb75bc0d Mon Sep 17 00:00:00 2001

From: Roger Quadros <[email protected]>
Date: Thu, 13 Aug 2015 13:28:42 +0300
Subject: usb: phy: phy-generic: Fix reset behaviour on legacy boot

From: Roger Quadros <[email protected]>

commit 762982db33b23029e98c844611e2e8beeb75bc0d upstream.

The gpio-desc migration done in v4.0 caused a regression with legacy boots due to reversed reset logic. e.g. omap3-beagle USB host breaks on legacy boot.

Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that it matches the driver logic and pin behaviour.

Fixes e9f2cefb0cdc ("usb: phy: generic: migrate to gpio_desc")
Tested-by Fabio Estevam <[email protected]>
Signed-off-by Roger Quadros <[email protected]>
Signed-off-by Felipe Balbi <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 drivers/usb/phy/phy-generic.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/phy/phy-generic.c +2 -1
@@ -230,7 +230,8 @@ int usb_phy_gen_create_phy(struct device
 		clk_rate = pdata->clk_rate;
 		needs_vcc = pdata->needs_vcc;
 		if (gpio_is_valid(pdata->gpio_reset)) {
-			err = devm_gpio_request_one(dev, pdata->gpio_reset, 0,
+			err = devm_gpio_request_one(dev, pdata->gpio_reset,
+						    GPIOF_ACTIVE_LOW,
 						    dev_name(dev));
 			if (!err)
 				nop->gpiod_reset =

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/usb-xhci-exit-early-in-xhci_setup_device-if-we-re-halted-or-dying.patch queue-4.2/usb-xhci-clear-xhci_state_dying-on-start.patch queue-4.2/extcon-fix-signedness-bugs-about-break-error-handling.patch queue-4.2/usb-xhci-stop-everything-on-the-first-call-to-xhci_stop.patch queue-4.2/usb-phy-phy-generic-fix-reset-behaviour-on-legacy-boot.patch queue-4.2/usb-xhci-lock-mutex-on-xhci_stop.patch