ASoC: ssm2518: Drop .volatile_reg implementation
Subsystems (3)
PATCH 1/2 ASoC: ssm2518: Drop .volatile_reg implementation
The implementation of ssm2518_register_volatile always returns false, this behavior is the same as no .volatile_reg callback implementation when cache_type != REGCACHE_NONE.
--- sound/soc/codecs/ssm2518.c | 6 ------ 1 file changed, 6 deletions(-)
sound/soc/codecs/ssm2518.c +0 -6
@@ -723,17 +723,11 @@ static struct snd_soc_codec_driver ssm2518_codec_driver = { .num_dapm_routes = ARRAY_SIZE(ssm2518_routes), }; -static bool ssm2518_register_volatile (struct device *dev,unsigned int reg) -{ -return false; -} -static const struct regmap_config ssm2518_regmap_config = { .val_bits =8 , .reg_bits =8 , .max_register =SSM2518_REG_DRC_9 , - .volatile_reg = ssm2518_register_volatile, .cache_type =REGCACHE_RBTREE , .reg_defaults = ssm2518_reg_defaults,
Signature · 1 line
2.1.4
PATCH 2/2 ASoC: ad193x: Drop .volatile_reg implementation
adau193x_reg_volatile() always return false.
This seems pointless because current code uses REGCACHE_NONE cache_type which is supposed to be volatile.
--- sound/soc/codecs/ad193x.c | 6 ------ 1 file changed, 6 deletions(-)
sound/soc/codecs/ad193x.c +0 -6
@@ -418,14 +418,8 @@ static struct snd_soc_codec_driver soc_codec_dev_ad193x = { .num_dapm_routes = ARRAY_SIZE(audio_paths), }; -static bool adau193x_reg_volatile (struct device *dev,unsigned int reg) -{ -return false; -} -const struct regmap_config ad193x_regmap_config = { .max_register =AD193X_NUM_REGS -1 , - .volatile_reg = adau193x_reg_volatile, };EXPORT_SYMBOL_GPL (ad193x_regmap_config);
Signature · 1 line
2.1.4
Re: [PATCH 2/2] ASoC: ad193x: Drop .volatile_reg implementation
Quoted 5 lines · Axel Lin
adau193x_reg_volatile()always return false.
This seems pointless because current code usesREGCACHE_NONEcache_typewhich is supposed to be volatile.Signed-off-by Axel Lin <[email protected]>
Thanks.
Mark Brown
maintainerApplied "ASoC: ad193x: Drop .volatile_reg implementation" to the asoc tree
In reply to Axel LinThe patch
ASoC: ad193x: Drop .volatile_reg implementation
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
92b822a499607c32ce12ffd798a095babedc3202Mon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Tue, 20 Oct 2015 16:56:11 +0800
Subject: [PATCH] ASoC: ad193x: Drop .volatile_reg implementation
adau193x_reg_volatile() always return false.
This seems pointless because current code uses REGCACHE_NONE cache_type which is supposed to be volatile.
--- sound/soc/codecs/ad193x.c | 6 ------ 1 file changed, 6 deletions(-)
sound/soc/codecs/ad193x.c +0 -6
@@ -418,14 +418,8 @@ static struct snd_soc_codec_driver soc_codec_dev_ad193x = { .num_dapm_routes = ARRAY_SIZE(audio_paths), }; -static bool adau193x_reg_volatile (struct device *dev,unsigned int reg) -{ -return false; -} -const struct regmap_config ad193x_regmap_config = { .max_register =AD193X_NUM_REGS -1 , - .volatile_reg = adau193x_reg_volatile, };EXPORT_SYMBOL_GPL (ad193x_regmap_config);
Signature · 1 line
2.6.1
Quoted 5 lines · Axel Lin
The implementation of
ssm2518_register_volatilealways returns false, this behavior is the same as no .volatile_reg callback implementation whencache_type!=REGCACHE_NONE.Signed-off-by Axel Lin <[email protected]>
Thanks.
Mark Brown
maintainerApplied "ASoC: ssm2518: Drop .volatile_reg implementation" to the asoc tree
In reply to Axel LinThe patch
ASoC: ssm2518: Drop .volatile_reg implementation
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
ce7b8dbdded8552d1fd25cc9289da361c5cc765eMon Sep 17 00:00:00 2001
From: Axel Lin <[email protected]>
Date: Tue, 20 Oct 2015 16:54:46 +0800
Subject: [PATCH] ASoC: ssm2518: Drop .volatile_reg implementation
The implementation of ssm2518_register_volatile always returns false, this behavior is the same as no .volatile_reg callback implementation when cache_type != REGCACHE_NONE.
--- sound/soc/codecs/ssm2518.c | 6 ------ 1 file changed, 6 deletions(-)
sound/soc/codecs/ssm2518.c +0 -6
@@ -723,17 +723,11 @@ static struct snd_soc_codec_driver ssm2518_codec_driver = { .num_dapm_routes = ARRAY_SIZE(ssm2518_routes), }; -static bool ssm2518_register_volatile (struct device *dev,unsigned int reg) -{ -return false; -} -static const struct regmap_config ssm2518_regmap_config = { .val_bits =8 , .reg_bits =8 , .max_register =SSM2518_REG_DRC_9 , - .volatile_reg = ssm2518_register_volatile, .cache_type =REGCACHE_RBTREE , .reg_defaults = ssm2518_reg_defaults,
Signature · 1 line
2.6.1