Skip to contentSkip to conversation

i40e: rework the functions to configure RSS with similar parameters

PATCH New Catherine Sullivan 2 participants 6 messages Oct 21, 2015 – Oct 27, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 13/15 i40e: rework the functions to configure RSS with similar parameters

From: Helin Zhang <[email protected]>

Adjust the RSS configure functions so that there is a generic way to hook to ethtool hooks.

Change-ID If446e34fcfaf1bc3320d9d319829a095b5976e67

---
Testing-hints: Test with next patch.

 drivers/net/ethernet/intel/i40e/i40e.h         |  1 +
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |  1 -
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 95 +++++++++++++++++++-------
 3 files changed, 71 insertions(+), 26 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +1 -0
index ca07a7b..f6b747c 100644
@@ -187,6 +187,7 @@ struct i40e_lump_tracking {
 #define I40E_FDIR_BUFFER_HEAD_ROOM_FOR_ATR (I40E_FDIR_BUFFER_HEAD_ROOM * 4)
 
 #define I40E_HKEY_ARRAY_SIZE ((I40E_PFQF_HKEY_MAX_INDEX + 1) * 4)
+#define I40E_HLUT_ARRAY_SIZE ((I40E_PFQF_HLUT_MAX_INDEX + 1) * 4)
 
 enum i40e_fd_stat_idx {
 	I40E_FD_STAT_ATR,
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +0 -1
index 9c243aa..9d66a00 100644
@@ -2578,7 +2578,6 @@ static int i40e_set_channels(struct net_device *dev,
 		return -EINVAL;
 }
 
-#define I40E_HLUT_ARRAY_SIZE ((I40E_PFQF_HLUT_MAX_INDEX + 1) * 4)
 /**
  * i40e_get_rxfh_key_size - get the RSS hash key size
  * @netdev: network interface device structure
drivers/net/ethernet/intel/i40e/i40e_main.c +70 -25

151 lines not on this page · raw message

Signature · 1 line
1.9.3
#1 lore raw

PATCH 14/15 i40e: create a generic configure rss function

From: Helin Zhang <[email protected]>

This patch renames the old pf-specific function in order to clarify its scope. This patch also creates a more generic configure RSS function with the old name.

This patch also creates a new more generic function to get RSS configuration, using the appropriate method.

Change-ID Ieddca2707b708ef19f1ebccdfd03a0a0cd63d3af

---
Testing-hints: Test RSS hooks from ethtool for X[L]710 and X722.

 drivers/net/ethernet/intel/i40e/i40e.h         |  2 +
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 72 ++++++++++------------
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 85 ++++++++++++++++++++++----
 3 files changed, 107 insertions(+), 52 deletions(-)
drivers/net/ethernet/intel/i40e/i40e.h +2 -0
index f6b747c..89f5323 100644
@@ -670,6 +670,8 @@ extern const char i40e_driver_name[];
 extern const char i40e_driver_version_str[];
 void i40e_do_reset_safe(struct i40e_pf *pf, u32 reset_flags);
 void i40e_do_reset(struct i40e_pf *pf, u32 reset_flags);
+int i40e_config_rss(struct i40e_vsi *vsi, u8 *seed, u8 *lut, u16 lut_size);
+int i40e_get_rss(struct i40e_vsi *vsi, u8 *seed, u8 *lut, u16 lut_size);
 struct i40e_vsi *i40e_find_vsi_from_id(struct i40e_pf *pf, u16 id);
 void i40e_update_stats(struct i40e_vsi *vsi);
 void i40e_update_eth_stats(struct i40e_vsi *vsi);
drivers/net/ethernet/intel/i40e/i40e_ethtool.c +31 -41

99 lines not on this page · raw message

drivers/net/ethernet/intel/i40e/i40e_main.c +74 -11

129 lines not on this page · raw message

Signature · 1 line
1.9.3
#2 lore raw

PATCH 14/15 i40e: create a generic configure rss function

Quoted 21 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Catherine Sullivan
Sent: Wednesday, October 21, 2015 4:56 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Zhang, Helin
Subject: [Intel-wired-lan] [next PATCH S19 14/15] i40e: create a generic configure rss function

From: Helin Zhang <[email protected]>

This patch renames the old pf-specific function in order to clarify its scope. This patch also creates a more generic configure RSS function with the old name.

This patch also creates a new more generic function to get RSS configuration, using the appropriate method.

Change-ID Ieddca2707b708ef19f1ebccdfd03a0a0cd63d3af
Quoted 7 lines

---
Testing-hints: Test RSS hooks from ethtool for X[L]710 and X722.

 drivers/net/ethernet/intel/i40e/i40e.h         |  2 +
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 72 ++++++++++------------
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 85
++++++++++++++++++++++----
 3 files changed, 107 insertions(+), 52 deletions(-)

Patch code changes correctly applied, settings with ethtool -X and -L set correctly, and persist across PF and global resets

#3 lore raw

PATCH 15/15 i40e: Bump version to 1.4.2

In reply to Catherine Sullivan

Bump.

Change-ID I2d1ce93b2ce74e4eef2394c932aef52cba99713f
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_main.c +2 -2
index cd6e278..97aded7 100644
@@ -38,8 +38,8 @@ static const char i40e_driver_string[] =
 #define DRV_KERN "-k"
 
 #define DRV_VERSION_MAJOR 1
-#define DRV_VERSION_MINOR 3
-#define DRV_VERSION_BUILD 46
+#define DRV_VERSION_MINOR 4
+#define DRV_VERSION_BUILD 2
 #define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \
 	     __stringify(DRV_VERSION_MINOR) "." \
 	     __stringify(DRV_VERSION_BUILD)    DRV_KERN
Signature · 1 line
1.9.3
#4 lore raw

PATCH 15/15 i40e: Bump version to 1.4.2

Quoted 7 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Catherine Sullivan
Sent: Wednesday, October 21, 2015 4:56 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [next PATCH S19 15/15] i40e: Bump version to 1.4.2

Quoted 7 lines

Bump.

Change-ID I2d1ce93b2ce74e4eef2394c932aef52cba99713f
---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch code changes correctly applied, modinfo i40e shows updated version number.

#5 lore raw

PATCH 13/15 i40e: rework the functions to configure RSS with similar parameters

In reply to Catherine Sullivan
Quoted 17 lines

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Catherine Sullivan
Sent: Wednesday, October 21, 2015 4:56 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Zhang, Helin
Subject: [Intel-wired-lan] [next PATCH S19 13/15] i40e: rework the functions to configure RSS with similar parameters

From: Helin Zhang <[email protected]>

Adjust the RSS configure functions so that there is a generic way to hook to ethtool hooks.

Change-ID If446e34fcfaf1bc3320d9d319829a095b5976e67
Quoted 7 lines

---
Testing-hints: Test with next patch.

 drivers/net/ethernet/intel/i40e/i40e.h         |  1 +
 drivers/net/ethernet/intel/i40e/i40e_ethtool.c |  1 -
 drivers/net/ethernet/intel/i40e/i40e_main.c    | 95
+++++++++++++++++++-------
 3 files changed, 71 insertions(+), 26 deletions(-)

Patch code changes correctly applied