Skip to contentSkip to conversation

ASoC: da7219: Use logical instead of bitwise OR for boolean expression

PATCH In review Axel Lin 3 participants 3 messages Oct 24, 2015 – Nov 2, 2015

Subsystems (3)
Sound ASoC Dialog semiconductor drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 ASoC: da7219: Use logical instead of bitwise OR for boolean expression

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/da7219.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/da7219.c +1 -1
index abba4b3..86c528a 100644
@@ -1306,7 +1306,7 @@ static int da7219_hw_params(struct snd_pcm_substream *substream,
 	}
 
 	channels = params_channels(params);
-	if ((channels < 1) | (channels > DA7219_DAI_CH_NUM_MAX)) {
+	if ((channels < 1) || (channels > DA7219_DAI_CH_NUM_MAX)) {
 		dev_err(codec->dev,
 			"Invalid number of channels, only 1 to %d supported\n",
 			DA7219_DAI_CH_NUM_MAX);
Signature · 1 line
2.1.4
maintainer
#1 lore raw

Applied "ASoC: da7219: Use logical instead of bitwise OR for boolean expression" to the asoc tree

The patch

ASoC: da7219: Use logical instead of bitwise OR for boolean expression

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 6b26f6172b77734386dbd728163d14165a2d89bf Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Sat, 24 Oct 2015 14:28:33 +0800
Subject: [PATCH] ASoC: da7219: Use logical instead of bitwise OR for boolean
expression

Signed-off-by Axel Lin <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/codecs/da7219.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/da7219.c +1 -1
index f238c1e..e36a7b7 100644
@@ -1306,7 +1306,7 @@ static int da7219_hw_params(struct snd_pcm_substream *substream,
 	}
 
 	channels = params_channels(params);
-	if ((channels < 1) | (channels > DA7219_DAI_CH_NUM_MAX)) {
+	if ((channels < 1) || (channels > DA7219_DAI_CH_NUM_MAX)) {
 		dev_err(codec->dev,
 			"Invalid number of channels, only 1 to %d supported\n",
 			DA7219_DAI_CH_NUM_MAX);
Signature · 1 line
2.6.1
Acked-by on v1 1/1
#2 lore raw
In reply to Axel Lin
Quoted 18 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/codecs/da7219.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/da7219.c +1 -1
index abba4b3..86c528a 100644
@@ -1306,7 +1306,7 @@ static int da7219_hw_params(struct snd_pcm_substream
 *substream,
 	}
 
 	channels = params_channels(params);
-	if ((channels < 1) | (channels > DA7219_DAI_CH_NUM_MAX)) {
+	if ((channels < 1) || (channels > DA7219_DAI_CH_NUM_MAX)) {
 		dev_err(codec->dev,
 			"Invalid number of channels, only 1 to %d supported\n",
Quoted 3 lines

DA7219_DAI_CH_NUM_MAX);
--
2.1.4

Acked-by Adam Thomson <[email protected]>