Skip to contentSkip to conversation

spi: altera_spi: Use BIT macro

PATCH New Jagan Teki 2 participants 4 messages Oct 27, 2015 – Oct 28, 2015 SPI

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH v6 3/23 spi: altera_spi: Use BIT macro

Replace numerical bit shift with BIT macro in altera_spi

:%s/(1 << nr)/BIT(nr)/g
where nr = 0, 1, 2 .... 31

Cc Marek Vasut <[email protected]>
Cc Thomas Chou <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signed-off-by Jagan Teki <[email protected]>

---
Changes for v6:
- Rebase to master

 drivers/spi/altera_spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/altera_spi.c +2 -2
index ff3512a..3dbcfaa 100644
@@ -38,8 +38,8 @@ struct altera_spi_priv {
 	struct altera_spi_regs *regs;
 };
 
-#define ALTERA_SPI_STATUS_RRDY_MSK	(1 << 7)
-#define ALTERA_SPI_CONTROL_SSO_MSK	(1 << 10)
+#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
+#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
 
 static void spi_cs_activate(struct udevice *dev, uint cs)
 {
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/1 spi: altera_spi: Minor cleanup

- Moved macro definitions to top
- Give tab space to CONFIG_ALTERA_SPI_IDLE_VAL value
- Re-arrange header includes to ascending order

Cc Thomas Chou <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
---
 drivers/spi/altera_spi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/spi/altera_spi.c +5 -5
index 3dbcfaa..e49949b 100644
@@ -11,14 +11,17 @@
 #include <dm.h>
 #include <errno.h>
 #include <malloc.h>
-#include <spi.h>
 #include <fdtdec.h>
+#include <spi.h>
 #include <asm/io.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
+#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
+#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
+
 #ifndef CONFIG_ALTERA_SPI_IDLE_VAL
-#define CONFIG_ALTERA_SPI_IDLE_VAL 0xff
+#define CONFIG_ALTERA_SPI_IDLE_VAL	0xff
 #endif
 
 struct altera_spi_regs {

@@ -38,9 +41,6 @@ struct altera_spi_priv {
 	struct altera_spi_regs *regs;
 };
 
-#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
-#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
-
 static void spi_cs_activate(struct udevice *dev, uint cs)
 {
 	struct udevice *bus = dev->parent;
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/1 spi: altera_spi: Minor cleanup

Hi Jagan,

Quoted 10 lines · Jagan Teki

- Moved macro definitions to top
- Give tab space to CONFIG_ALTERA_SPI_IDLE_VAL value
- Re-arrange header includes to ascending order

Cc Thomas Chou <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
---
  drivers/spi/altera_spi.c | 10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by Thomas Chou <[email protected]>

Thanks a lot.

Best regards,
Thomas Chou

Quoted 35 lines
drivers/spi/altera_spi.c +5 -5
index 3dbcfaa..e49949b 100644
@@ -11,14 +11,17 @@
  #include <dm.h>
  #include <errno.h>
  #include <malloc.h>
-#include <spi.h>
  #include <fdtdec.h>
+#include <spi.h>
  #include <asm/io.h>
 
  DECLARE_GLOBAL_DATA_PTR;
 
+#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
+#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
+
  #ifndef CONFIG_ALTERA_SPI_IDLE_VAL
-#define CONFIG_ALTERA_SPI_IDLE_VAL 0xff
+#define CONFIG_ALTERA_SPI_IDLE_VAL	0xff
  #endif
 
  struct altera_spi_regs {

@@ -38,9 +41,6 @@ struct altera_spi_priv {
  	struct altera_spi_regs *regs;
  };
 
-#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
-#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
-
  static void spi_cs_activate(struct udevice *dev, uint cs)
  {
  	struct udevice *bus = dev->parent;
#3 lore raw

PATCH v6 3/23 spi: altera_spi: Use BIT macro

In reply to Jagan Teki

HI Jagan,

Quoted 10 lines · Jagan Teki

Replace numerical bit shift with BIT macro in altera_spi

:%s/(1 << nr)/BIT(nr)/g
where nr = 0, 1, 2 .... 31

Cc Marek Vasut <[email protected]>
Cc Thomas Chou <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signed-off-by Jagan Teki <[email protected]>
Quoted 7 lines

---
Changes for v6:
- Rebase to master

  drivers/spi/altera_spi.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by Thomas Chou <[email protected]>

Thanks a lot.

Best regards,
Thomas Chou

Quoted 16 lines
drivers/spi/altera_spi.c +2 -2
index ff3512a..3dbcfaa 100644
@@ -38,8 +38,8 @@ struct altera_spi_priv {
  	struct altera_spi_regs *regs;
  };
 
-#define ALTERA_SPI_STATUS_RRDY_MSK	(1 << 7)
-#define ALTERA_SPI_CONTROL_SSO_MSK	(1 << 10)
+#define ALTERA_SPI_STATUS_RRDY_MSK	BIT(7)
+#define ALTERA_SPI_CONTROL_SSO_MSK	BIT(10)
 
  static void spi_cs_activate(struct udevice *dev, uint cs)
  {