Skip to contentSkip to conversation

vmcore-dmesg: Collect full dmesg regardless of logged_chars

PATCH Superseded Dangyi Liu 1 participant 1 message Oct 28, 2015

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Dangyi Liu

author
#0 lore raw

PATCH 1/1 vmcore-dmesg: Collect full dmesg regardless of logged_chars

logged_chars would be set to 0 by dmesg -c, but full dmesg is useful for debugging. So instead of using logged_chars directly, we calculate it by ourselves.

Now logged_chars is set to the minimum of log_end and log_buf_len, as the same logic as crash utility is using.

---
 vmcore-dmesg/vmcore-dmesg.c | 6 ++++++
 1 file changed, 6 insertions(+)
vmcore-dmesg/vmcore-dmesg.c +6 -0
index f47ee11..134a4ef 100644
@@ -540,6 +540,12 @@ static void dump_dmesg_legacy(int fd)
 		exit(53);
 	}
 
+	/*
+	 * To collect full dmesg including the part before `dmesg -c` is useful for
+	 * later debugging. Use same logic as what crash utility is using.
+	 */
+	logged_chars = log_end < log_buf_len ? log_end : log_buf_len;
+
 	write_to_stdout(buf + (log_buf_len -  logged_chars), logged_chars);
 }
 
Signature · 7 lines
2.4.3


_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec