Skip to contentSkip to conversation

MIPS: fix build failure

PATCH In review Sudip Mukherjee 2 participants 4 messages Oct 28, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MIPS: fix build failure

While building for mips defconfig the build failed with the error:
In function 'create_elf_tables':
arch/mips/include/asm/elf.h:425:14: error:
'AT_SYSINFO_EHDR' undeclared (first use in this function)

AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included here.

Fixes c1fb442ade67 ("MIPS: Initial implementation of a VDSO")

---

This patch is based on mips-for-linux-next branch.

 arch/mips/include/asm/elf.h | 1 +
 1 file changed, 1 insertion(+)
arch/mips/include/asm/elf.h +1 -0
index b01a6ff..acd6da2 100644
@@ -11,6 +11,7 @@
 #include <linux/auxvec.h>
 #include <linux/fs.h>
 #include <uapi/linux/elf.h>
+#include <uapi/asm/auxvec.h>
 
 #include <asm/cpu-info.h>
 #include <asm/current.h>
Signature · 1 line
1.9.1
#1 lore raw
Quoted 5 lines · Sudip Mukherjee

While building for mips defconfig the build failed with the error:
In function 'create_elf_tables':
arch/mips/include/asm/elf.h:425:14: error:
'AT_SYSINFO_EHDR' undeclared (first use in this function)

Quoted 9 lines

AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included here.

Fixes c1fb442ade67 ("MIPS: Initial implementation of a VDSO")

---

This patch is based on mips-for-linux-next branch.

Something is not right here. The <linux/auxvec.h> header is already included in that file which in turns includes uapi/asm/auxvec.h

I haven't seen this failure in Ralf's tree. Could you share your .config and perhaps the hash of the mips-for-linux-next tree you tried it on?

Signature · 1 line
markos
#2 lore raw
Quoted 13 lines · Markos Chandras
Quoted 12 lines · Sudip Mukherjee

While building for mips defconfig the build failed with the error:
In function 'create_elf_tables':
arch/mips/include/asm/elf.h:425:14: error:
'AT_SYSINFO_EHDR' undeclared (first use in this function)

AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included here.

Fixes c1fb442ade67 ("MIPS: Initial implementation of a VDSO")

---

Quoted 10 lines
Quoted 2 lines

This patch is based on mips-for-linux-next branch.

Something is not right here. The <linux/auxvec.h> header is already included in that file which in turns includes uapi/asm/auxvec.h

I haven't seen this failure in Ralf's tree. Could you share your .config and perhaps the hash of the mips-for-linux-next tree you tried it on?

I believe your problem might be similar to this

https://www.linux-mips.org/archives/linux-mips/2015-10/msg00280.html

in other words either remove the generated headers or do a 'make mrproper' (make sure to backup your .config) and try again

Signature · 1 line
markos
#3 lore raw
Quoted 24 lines · Markos Chandras
Quoted 13 lines · Markos Chandras
Quoted 12 lines · Sudip Mukherjee

While building for mips defconfig the build failed with the error:
In function 'create_elf_tables':
arch/mips/include/asm/elf.h:425:14: error:
'AT_SYSINFO_EHDR' undeclared (first use in this function)

AT_SYSINFO_EHDR is defined in uapi/asm/auxvec.h which was not included here.

Fixes c1fb442ade67 ("MIPS: Initial implementation of a VDSO")

---

Quoted 10 lines
Quoted 2 lines

This patch is based on mips-for-linux-next branch.

Something is not right here. The <linux/auxvec.h> header is already included in that file which in turns includes uapi/asm/auxvec.h

I haven't seen this failure in Ralf's tree. Could you share your .config and perhaps the hash of the mips-for-linux-next tree you tried it on?

Quoted 6 lines

I believe your problem might be similar to this

https://www.linux-mips.org/archives/linux-mips/2015-10/msg00280.html

in other words either remove the generated headers or do a 'make mrproper' (make sure to backup your .config) and try again

Yes, I did a make distclean to be sure everything is clean. And it builds properly. Please discard the patch.
Sorry for the noise.

regards
sudip