drm/i915: disable CPU PWM also on LPT/SPT backlight disable
Subsystems (2)
PATCH RESEND 1/1 drm/i915: disable CPU PWM also on LPT/SPT backlight disable
Although we don't support or enable CPU PWM with LPT/SPT based systems, it may have been enabled prior to loading the driver. Disable the CPU PWM on LPT/SPT backlight disable to avoid warnings on LCPLL disable.
The issue has been present on BDW since BDW enabling, but was recently introduced on HSW with
commit 437b15b8017e0d946453c10794b0c5d4591cf180
Author: Jani Nikula <[email protected]> Date: Fri Sep 4 16:55:13 2015 +0300
drm/i915: use pch backlight override on hsw too
Cc: Paulo Zanoni <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Reference: http://mid.gmane.org/[email protected]
--- drivers/gpu/drm/i915/intel_panel.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/gpu/drm/i915/intel_panel.c +14 -0
@@ -732,6 +732,20 @@ static void lpt_disable_backlight(struct intel_connector *connector)intel_panel_actually_set_backlight (connector,0 ); +/* +* Although we don't support or enable CPU PWM with LPT/SPT based +* systems, it may have been enabled prior to loading the +* driver. Disable to avoid warnings on LCPLL disable. +* +* This needs rework if we need to add support for CPU PWM on PCH split +* platforms. +*/ + tmp =I915_READ (BLC_PWM_CPU_CTL2 ); +if (tmp &BLM_PWM_ENABLE ) { +DRM_DEBUG_KMS ("cpu backlight was enabled, disabling\n" ); +I915_WRITE (BLC_PWM_CPU_CTL2 , tmp & ~BLM_PWM_ENABLE ); + } + tmp =I915_READ (BLC_PWM_PCH_CTL1 );I915_WRITE (BLC_PWM_PCH_CTL1 , tmp & ~BLM_PCH_PWM_ENABLE ); }
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Jani Nikula
Although we don't support or enable CPU PWM with LPT/SPT based systems, it may have been enabled prior to loading the driver. Disable the CPU PWM on LPT/SPT backlight disable to avoid warnings on LCPLL disable.
The issue has been present on BDW since BDW enabling, but was recently introduced on HSW with
commit
437b15b8017e0d946453c10794b0c5d4591cf180Author: Jani Nikula <[email protected]> Date: Fri Sep 4 16:55:13 2015 +0300
Quoted 7 lines
drm/i915: use pch backlight override on hsw too
Cc: Paulo Zanoni <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Reference: http://mid.gmane.org/[email protected]Reported-by kernel test robot <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Not seeing the warning anymore during ./scripts/run-tests.sh -t basic -x reload -x suspend on my HSW-ULT
Quoted 31 lines
--- drivers/gpu/drm/i915/intel_panel.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)drivers/gpu/drm/i915/intel_panel.c +14
-0@@ -732,6 +732,20 @@ static void lpt_disable_backlight(struct intel_connector *connector)intel_panel_actually_set_backlight (connector,0 ); +/* +* Although we don't support or enable CPU PWM with LPT/SPT based +* systems, it may have been enabled prior to loading the +* driver. Disable to avoid warnings on LCPLL disable. +* +* This needs rework if we need to add support for CPU PWM on PCH split +* platforms. +*/ + tmp =I915_READ (BLC_PWM_CPU_CTL2 ); +if (tmp &BLM_PWM_ENABLE ) { +DRM_DEBUG_KMS ("cpu backlight was enabled, disabling\n" ); +I915_WRITE (BLC_PWM_CPU_CTL2 , tmp & ~BLM_PWM_ENABLE ); + } + tmp =I915_READ (BLC_PWM_PCH_CTL1 );I915_WRITE (BLC_PWM_PCH_CTL1 , tmp & ~BLM_PCH_PWM_ENABLE ); }Signature · 1 line
2.1.4
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 20 lines · Ville Syrjälä
Quoted 11 lines · Jani Nikula
Although we don't support or enable CPU PWM with LPT/SPT based systems, it may have been enabled prior to loading the driver. Disable the CPU PWM on LPT/SPT backlight disable to avoid warnings on LCPLL disable.
The issue has been present on BDW since BDW enabling, but was recently introduced on HSW with
commit
437b15b8017e0d946453c10794b0c5d4591cf180Author: Jani Nikula <[email protected]> Date: Fri Sep 4 16:55:13 2015 +0300Quoted 7 lines
drm/i915: use pch backlight override on hsw too
Cc: Paulo Zanoni <[email protected]>
Cc: Ville Syrjälä <[email protected]>
Reference: http://mid.gmane.org/[email protected]Reported-by kernel test robot <[email protected]>Signed-off-by Jani Nikula <[email protected]>
Quoted 5 lines
Not seeing the warning anymore during
./scripts/run-tests.sh-t basic -x reload -x suspend on my HSW-ULTTested-by Ville Syrjälä <[email protected]>
Thanks, pushed to drm-intel-next-fixes.
BR,
Jani.
Quoted 36 lines
Quoted 32 lines
--- drivers/gpu/drm/i915/intel_panel.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)drivers/gpu/drm/i915/intel_panel.c +14
-0@@ -732,6 +732,20 @@ static void lpt_disable_backlight(struct intel_connector *connector)intel_panel_actually_set_backlight (connector,0 ); +/* +* Although we don't support or enable CPU PWM with LPT/SPT based +* systems, it may have been enabled prior to loading the +* driver. Disable to avoid warnings on LCPLL disable. +* +* This needs rework if we need to add support for CPU PWM on PCH split +* platforms. +*/ + tmp =I915_READ (BLC_PWM_CPU_CTL2 ); +if (tmp &BLM_PWM_ENABLE ) { +DRM_DEBUG_KMS ("cpu backlight was enabled, disabling\n" ); +I915_WRITE (BLC_PWM_CPU_CTL2 , tmp & ~BLM_PWM_ENABLE ); + } + tmp =I915_READ (BLC_PWM_PCH_CTL1 );I915_WRITE (BLC_PWM_PCH_CTL1 , tmp & ~BLM_PCH_PWM_ENABLE ); }Signature · 1 line
2.1.4Signature · 2 lines
Ville Syrjälä Intel OTC
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx