Skip to contentSkip to conversation

drivers:staging:gdm72xx Fix line over 80 characters

PATCH In review Bogicevic Sasa 2 participants 3 messages Oct 31, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 drivers:staging:gdm72xx Fix line over 80 characters

This fixes line over 80 characters message from checkpatch.pl

---
 drivers/staging/gdm72xx/gdm_qos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/gdm72xx/gdm_qos.c +2 -1
index c03204b..0625a54 100644
@@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
 
 		spin_lock_irqsave(&qcb->qos_lock, flags);
 		qcb->csr[index].sfid = sfid;
-		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
+		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
+							0xff00);
 		qcb->csr[index].classifier_rule_en += buf[pos++];
 		if (qcb->csr[index].classifier_rule_en == 0)
 			qcb->qos_null_idx = index;
Signature · 1 line
2.1.4
#1 lore raw
Quoted 1 line · Bogicevic Sasa

This fixes line over 80 characters message from checkpatch.pl

[]

drivers/staging/gdm72xx/gdm_qos.c

Quoted 1 line
drivers/staging/gdm72xx/gdm_qos.c +0 -0

[]

drivers/staging/gdm72xx/gdm_qos.c void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) · line 386

Quoted 7 lines
drivers/staging/gdm72xx/gdm_qos.c +2 -1
@@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
 
 		spin_lock_irqsave(&qcb->qos_lock, flags);
 		qcb->csr[index].sfid = sfid;
-		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
+		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
+							0xff00);

Probably better to remove the unnecessary parentheses instead

		qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00;
#2 lore raw
Quoted 15 lines · Joe Perches
Quoted 1 line · Bogicevic Sasa

This fixes line over 80 characters message from checkpatch.pl

[]

drivers/staging/gdm72xx/gdm_qos.c

Quoted 1 line
drivers/staging/gdm72xx/gdm_qos.c +0 -0

[]

drivers/staging/gdm72xx/gdm_qos.c void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size) · line 386

Quoted 7 lines
drivers/staging/gdm72xx/gdm_qos.c +2 -1
@@ -382,7 +382,8 @@ void gdm_recv_qos_hci_packet(void *nic_ptr, u8 *buf, int size)
 
 		spin_lock_irqsave(&qcb->qos_lock, flags);
 		qcb->csr[index].sfid = sfid;
-		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) & 0xff00);
+		qcb->csr[index].classifier_rule_en = ((buf[pos++] << 8) &
+							0xff00);

Probably better to remove the unnecessary parentheses instead

Quoted 4 lines
		qcb->csr[index].classifier_rule_en = (buf[pos++] << 8) & 0xff00;

You're right, I just sent a new patch.

Thanks, Sasa