Patch "ARM: EXYNOS: Fix double of_node_put() when parsing child power domains" has been added to the 4.2-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
ARM: EXYNOS: Fix double of_node_put() when parsing child power domains
to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
arm-exynos-fix-double-of_node_put-when-parsing-child-power-domains.patch
and it can be found in the queue-4.2 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
51a6256b00008a3c520f6f31bcd62cd15cb05960Mon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Tue, 13 Oct 2015 04:32:49 +0900
Subject: ARM: EXYNOS: Fix double of_node_put() when parsing child power domains
From: Krzysztof Kozlowski <[email protected]>
commit 51a6256b00008a3c520f6f31bcd62cd15cb05960 upstream.
On each next iteration of for_each_compatible_node() the reference counter for current device node is already decreased by the loop iterator. The manual call to of_node_get() is required only on loop break which is not happening here.
The double of_node_get() (with enabled CONFIG_OF_DYNAMIC) lead to decreasing the counter below expected, initial value.
--- arch/arm/mach-exynos/pm_domains.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
arch/arm/mach-exynos/pm_domains.c +3 -5
@@ -200,15 +200,15 @@ no_clk: args.args_count =0 ; child_domain =of_genpd_get_from_provider (&args);if (IS_ERR (child_domain)) - goto next_pd; +continue ;if (of_parse_phandle_with_args (np,"power-domains" ,"#power-domain-cells" ,0 , &args) !=0 ) - goto next_pd; +continue ; parent_domain =of_genpd_get_from_provider (&args);if (IS_ERR (parent_domain)) - goto next_pd; +continue ;if (pm_genpd_add_subdomain (parent_domain, child_domain)) pr_warn("%s failed to add subdomain: %s\n",
@@ -216,8 +216,6 @@ no_clk:else pr_info ("%s has as child subdomain: %s.\n" , parent_domain->name, child_domain->name); -next_pd: -of_node_put (np); }return 0 ;
Patches currently in stable-queue which might be from [email protected] are
queue-4.2/arm-exynos-fix-double-of_node_put-when-parsing-child-power-domains.patch queue-4.2/arm-dts-fix-audio-card-detection-on-peach-boards.patch