Skip to contentSkip to conversation

Patch "Revert "serial: 8250_dma: don't bother DMA with small transfers"" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Nov 6, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

Revert "serial: 8250_dma: don't bother DMA with small transfers"

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
revert-serial-8250_dma-don-t-bother-dma-with-small-transfers.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From f967fc8f165fadb72166f2bd4785094b3ca21307 Mon Sep 17 00:00:00 2001

From: Frederic Danis <[email protected]>
Date: Fri, 9 Oct 2015 17:14:56 +0200
Subject: Revert "serial: 8250_dma: don't bother DMA with small transfers"

From: Frederic Danis <[email protected]>

commit f967fc8f165fadb72166f2bd4785094b3ca21307 upstream.

This reverts commit 9119fba0cfeda6d415c9f068df66838a104b87cb.

This commit prevents from sending "big" file using Bluetooth. When sending a lot of data quickly through the Bluetooth interface, and after a variable amount of data sent, transfer fails with error:

    kernel: [  415.247453] Bluetooth: hci0 hardware error 0x00

Found on T100TA.

After reverting this commit, send works fine for any file size.

Fixes 9119fba0cfed (serial: 8250_dma: don't bother DMA with small transfers)
---
 drivers/tty/serial/8250/8250_dma.c |    4 ----
 1 file changed, 4 deletions(-)
drivers/tty/serial/8250/8250_dma.c +0 -4
@@ -80,10 +80,6 @@ int serial8250_tx_dma(struct uart_8250_p
 		return 0;
 
 	dma->tx_size = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
-	if (dma->tx_size < p->port.fifosize) {
-		ret = -EINVAL;
-		goto err;
-	}
 
 	desc = dmaengine_prep_slave_single(dma->txchan,
 					   dma->tx_addr + xmit->tail,

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/revert-serial-8250_dma-don-t-bother-dma-with-small-transfers.patch