Skip to contentSkip to conversation

hackrf: moving pointer reference before kfree

PATCH New Saurabh Sengar 1 participant 1 message Nov 6, 2015

Subsystems (2)
Media (V4L/DVB) Hackrf media driver
lore
Share & tools
lore

Saurabh Sengar

author
#0 lore raw

PATCH 1/1 hackrf: moving pointer reference before kfree

accessing a pointer after free could possible lead to segmentation fault, hence correcting it

Signed-off-by Saurabh Sengar <[email protected]>
---
 drivers/media/usb/hackrf/hackrf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/hackrf/hackrf.c +1 -1
index e05bfec..faf3670 100644
@@ -1528,9 +1528,9 @@ err_v4l2_ctrl_handler_free_tx:
 err_v4l2_ctrl_handler_free_rx:
 	v4l2_ctrl_handler_free(&dev->rx_ctrl_handler);
 err_kfree:
+	dev_dbg(dev->dev, "failed=%d\n", ret);
 	kfree(dev);
 err:
-	dev_dbg(dev->dev, "failed=%d\n", ret);
 	return ret;
 }
Signature · 1 line
1.9.1