Skip to contentSkip to conversation

stm class/intel_th: Kconfig fixes

PATCH Superseded Alexander Shishkin 1 participant 3 messages Nov 9, 2015

Subsystems (4)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Alexander Shishkin

author maintainer
#0 lore raw

cover stm class/intel_th: Kconfig fixes

Hi Greg,

These are two Kconfig fixes from Geert. 1/2 is the one that Linus noticed, 2/2 is a fresh one.

Geert Uytterhoeven (2):
stm class: Hide STM-specific options if STM is disabled
intel_th: INTEL_TH should depend on HAS_DMA

 drivers/hwtracing/intel_th/Kconfig | 1 +
 drivers/hwtracing/stm/Kconfig      | 4 ++++
 2 files changed, 5 insertions(+)
Signature · 1 line
2.6.2
author maintainer
#1 lore raw

PATCH 1/2 stm class: Hide STM-specific options if STM is disabled

From: Geert Uytterhoeven <[email protected]>

If STM=n, it doesn't make sense to ask about STM_DUMMY and STM_SOURCE_CONSOLE support, which are not even built when enabled anyway. Hence hide these options if STM=n.

---
 drivers/hwtracing/stm/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)
drivers/hwtracing/stm/Kconfig +4 -0
index 83e9f591a5..4c13762f2b 100644
@@ -8,6 +8,8 @@ config STM
 
 	  Say Y here to enable System Trace Module device support.
 
+if STM
+
 config STM_DUMMY
 	tristate "Dummy STM driver"
 	help
@@ -24,3 +26,5 @@ config STM_SOURCE_CONSOLE
 
 	  If you want to send kernel console messages over STM devices,
 	  say Y.
+
+endif
Signature · 1 line
2.6.2
author maintainer
#2 lore raw

PATCH 2/2 intel_th: INTEL_TH should depend on HAS_DMA

In reply to Alexander Shishkin

From: Geert Uytterhoeven <[email protected]>

If NO_DMA=y:

ERROR: "dma_free_coherent" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/hwtracing/intel_th/intel_th_msu.ko] undefined!
ERROR: "dma_supported" [drivers/hwtracing/intel_th/intel_th.ko] undefined!

Add a dependency on HAS_DMA to fix this.

---
 drivers/hwtracing/intel_th/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/hwtracing/intel_th/Kconfig +1 -0
index b7a9073d96..90b0844093 100644
@@ -1,5 +1,6 @@
 config INTEL_TH
 	tristate "Intel(R) Trace Hub controller"
+	depends on HAS_DMA
 	help
 	  Intel(R) Trace Hub (TH) is a set of hardware blocks (subdevices) that
 	  produce, switch and output trace data from multiple hardware and
Signature · 1 line
2.6.2