nfs:Fix error checking in the function nfs4_proc_setattr
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines · Nicholas Krause
This fixes error checking in the function
nfs4_proc_setattrto properly check and return a error code if the call to the functionpnfs_commit_and_return_layouthas failed by returning a error code as we cannot continue in the functionnfs4_proc_settattrafter this error code has been returned by the function,pnfs_commit_and_return.
Why not? It really is just advisory... On those architectures that require it, the pNFS server still has a responsibility to recall any outstanding layouts anyway when it receives a SETATTR call. The pnfs_commit_and_return here should mainly be an optimisation to avoid an unnecessary recall from the server, but we don't need to rely on it.
Cheers
Trond