Patch "net: Fix prefsrc lookups" has been added to the 4.3-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
net: Fix prefsrc lookups
to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-fix-prefsrc-lookups.patch
and it can be found in the queue-4.3 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Nov 17 14:33:46 PST 2015
From: David Ahern <[email protected]>
Date: Tue, 3 Nov 2015 15:59:28 -0800
Subject: net: Fix prefsrc lookups
From: David Ahern <[email protected]>
[ Upstream commit e1b8d903c6c3862160d2d5036806a94786c8fc4e ]
A bug report (https://bugzilla.kernel.org/show_bug.cgi?id=107071) noted that the follwoing ip command is failing with v4.3:
$ ip route add 10.248.5.0/24 dev bond0.250 table vlan_250 src 10.248.5.154
RTNETLINK answers: Invalid argument021dd3b8a142d changed the lookup of the given preferred source address to use the table id passed in, but this assumes the local entries are in the given table which is not necessarily true for non-VRF use cases. When validating the preferred source fallback to the local table on failure.
--- net/ipv4/fib_semantics.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
net/ipv4/fib_semantics.c +10 -3
@@ -864,14 +864,21 @@ static bool fib_valid_prefsrc(struct fibif (cfg->fc_type !=RTN_LOCAL || !cfg->fc_dst || fib_prefsrc != cfg->fc_dst) {u32 tb_id = cfg->fc_table; +int rc;if (tb_id ==RT_TABLE_MAIN ) tb_id =RT_TABLE_LOCAL ; -if (inet_addr_type_table (cfg->fc_nlinfo.nl_net, - fib_prefsrc, tb_id) !=RTN_LOCAL ) { -return false; + rc =inet_addr_type_table (cfg->fc_nlinfo.nl_net, + fib_prefsrc, tb_id); + +if (rc !=RTN_LOCAL && tb_id !=RT_TABLE_LOCAL ) { + rc =inet_addr_type_table (cfg->fc_nlinfo.nl_net, + fib_prefsrc,RT_TABLE_LOCAL ); } + +if (rc !=RTN_LOCAL ) +return false; }return true; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.3/net-fix-prefsrc-lookups.patch