patch "usb: gadget: atmel_usba_udc: Expose correct device speed" added to usb-linus
This is a note to let you know that I've just added the patch titled
usb: gadget: atmel_usba_udc: Expose correct device speed
to my usb git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
in the usb-linus branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
Quoted 1 line
From
d134c48d889ddceadf4c990e6f3df16b816ed5d4Mon Sep 17 00:00:00 2001
From: Douglas Gilbert <[email protected]>
Date: Mon, 16 Nov 2015 19:22:08 +0100
Subject: usb: gadget: atmel_usba_udc: Expose correct device speed
Following changes that appeared in lk 4.0.0, the gadget udc driver for some ARM based Atmel SoCs (e.g. at91sam9x5 and sama5d3 families) incorrectly deduced full-speed USB link speed even when the hardware had negotiated a high-speed link. The fix is to make sure that the UDPHS Interrupt Enable Register value does not mask the SPEED bit in the Interrupt Status Register.
For a mass storage gadget this problem lead to failures when the host had a USB 3 port with the xhci_hcd driver. If the host was a USB 2 port using the ehci_hcd driver then the mass storage gadget worked (but probably at a lower speed than it should have).
--- drivers/usb/gadget/udc/atmel_usba_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/atmel_usba_udc.c +1 -1
@@ -1633,7 +1633,7 @@ static irqreturn_t usba_udc_irq(int irq, void *devid)spin_lock (&udc->lock); int_enb =usba_int_enb_get (udc); - status =usba_readl (udc,INT_STA ) & int_enb; + status =usba_readl (udc,INT_STA ) & (int_enb |USBA_HIGH_SPEED );DBG (DBG_INT ,"irq, status=%#08x\n" , status);if (status &USBA_DET_SUSPEND ) {
Signature · 1 line
2.6.2