Skip to contentSkip to conversation

misc: mic: ERR_PTR expects -Exxx

PATCH New Rasmus Villemoes 1 participant 1 message Nov 20, 2015 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: mic: ERR_PTR expects -Exxx

These wouldn't be recognized by IS_ERR. There's no actual harm done, since the only caller ignores the return value.

---
 drivers/misc/mic/scif/scif_dma.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/misc/mic/scif/scif_dma.c +2 -2
index 95a13c629a8e..f998daad1993 100644
@@ -293,13 +293,13 @@ scif_add_mmu_notifier(struct mm_struct *mm, struct scif_endpt *ep)
 		 = kzalloc(sizeof(*mmn), GFP_KERNEL);
 
 	if (!mmn)
-		return ERR_PTR(ENOMEM);
+		return ERR_PTR(-ENOMEM);
 
 	scif_init_mmu_notifier(mmn, current->mm, ep);
 	if (mmu_notifier_register(&mmn->ep_mmu_notifier,
 				  current->mm)) {
 		kfree(mmn);
-		return ERR_PTR(EBUSY);
+		return ERR_PTR(-EBUSY);
 	}
 	list_add(&mmn->list, &ep->rma_info.mmn_list);
 	return mmn;
Signature · 1 line
2.6.1