Skip to contentSkip to conversation

configure.ac: use $withval with AC_ARG_WITH

PATCH New Samuel Martin 2 participants 5 messages Nov 22, 2015 – Dec 1, 2015 4 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 configure.ac: use $withval with AC_ARG_WITH

---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -1
index fad4de6..978e3bc 100644
@@ -315,7 +315,7 @@ AC_ARG_WITH(lttng-ust-prefix,
 # Check liblttng-ust-ctl library
 AC_ARG_WITH(lttng-ust,
 	AS_HELP_STRING([--without-lttng-ust],[build without LTTng-UST (Userspace Tracing) support]),
-	lttng_ust_support=$enableval, lttng_ust_support=yes)
+	lttng_ust_support=$withval, lttng_ust_support=yes)
 
 AS_IF([test "x$lttng_ust_support" = "xyes"], [
 	AC_CHECK_LIB([lttng-ust-ctl], [ustctl_recv_channel_from_consumer],
Signature · 1 line
2.6.2

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Hi all,

Quoted 1 line · Samuel Martin

---

Quoted 17 lines
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -2
index fad4de6..978e3bc 100644
@@ -315,7 +315,7 @@ AC_ARG_WITH(lttng-ust-prefix,
 # Check liblttng-ust-ctl library
 AC_ARG_WITH(lttng-ust,
        AS_HELP_STRING([--without-lttng-ust],[build without LTTng-UST (Userspace Tracing) support]),
-       lttng_ust_support=$enableval, lttng_ust_support=yes)
+       lttng_ust_support=$withval, lttng_ust_support=yes)
 
 AS_IF([test "x$lttng_ust_support" = "xyes"], [
        AC_CHECK_LIB([lttng-ust-ctl], [ustctl_recv_channel_from_consumer],
--
Quoted 2 lines

2.6.2

For the record, I just file a bug:
https://bugs.lttng.org/issues/980

Cheers,

Signature · 1 line
Samuel

A message that is not in the archive (sent off-list or not yet received): CAHXCMMJhOK9ELj=aKNGiGw_fmgTH46=6hedEXNaX0rvrOBdgmw@mail.gmail.com

#5 lore raw

Merged, thanks!

Jérémie

Quoted 37 lines · Samuel Martin

Hi all,

Quoted 1 line · Samuel Martin

---

Quoted 17 lines
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configure.ac +1 -2
index fad4de6..978e3bc 100644
@@ -315,7 +315,7 @@ AC_ARG_WITH(lttng-ust-prefix,
 # Check liblttng-ust-ctl library
 AC_ARG_WITH(lttng-ust,
        AS_HELP_STRING([--without-lttng-ust],[build without LTTng-UST (Userspace Tracing) support]),
-       lttng_ust_support=$enableval, lttng_ust_support=yes)
+       lttng_ust_support=$withval, lttng_ust_support=yes)
 
 AS_IF([test "x$lttng_ust_support" = "xyes"], [
        AC_CHECK_LIB([lttng-ust-ctl], [ustctl_recv_channel_from_consumer],
--
Quoted 2 lines

2.6.2

For the record, I just file a bug:
https://bugs.lttng.org/issues/980

Cheers,

--
Samuel

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 8 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
#6 lore raw

Re: [PATCH lttng-tools] configure.ac: fix static build

In reply to a message not in the archive

Hi all,

Quoted 11 lines · Samuel Martin

For static build, some extra LDFLAGS may be needed.

Using PKG_CHECK_MODULES instead of AC_CHECK_LIB for librairy detection allows to get all these flags. Then, the LIBS variable can be extended with everything that is needed.

So, use PKG_CHECK_MODULES for popt and uuid detection; which both depend on libintl.

This changes fixes build failures triggered with Buildroot, e.g.:
http://autobuild.buildroot.net/results/0f1/0f1e015a0c5a5ac2beeb5011d31a1e0058a32a0d/build-end.log

For the record, I just file a bug report about it:
https://bugs.lttng.org/issues/979

Cheers,

A message that is not in the archive (sent off-list or not yet received): CAHXCMMK10==xWormWDQ972=XoymwdCzGZaouRct88nh6nVbABg@mail.gmail.com

#8 lore raw

Re: [PATCH lttng-tools] configure.ac: fix static build

Merged in master, stable-2.7 and stable-2.6, thanks!

Jérémie

Quoted 24 lines · Samuel Martin

Hi all,

Quoted 11 lines · Samuel Martin

For static build, some extra LDFLAGS may be needed.

Using PKG_CHECK_MODULES instead of AC_CHECK_LIB for librairy detection allows to get all these flags. Then, the LIBS variable can be extended with everything that is needed.

So, use PKG_CHECK_MODULES for popt and uuid detection; which both depend on libintl.

This changes fixes build failures triggered with Buildroot, e.g.:
http://autobuild.buildroot.net/results/0f1/0f1e015a0c5a5ac2beeb5011d31a1e0058a32a0d/build-end.log

For the record, I just file a bug report about it:
https://bugs.lttng.org/issues/979

Cheers,

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 8 lines
Jérémie Galarneau
EfficiOS Inc.
http://www.efficios.com

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev