Skip to contentSkip to conversation

Client-side part for server restart notification

PATCH In review Lev Stipakov 3 participants 3 messages Nov 23, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Client-side part for server restart notification

When client receives "RESTART,N", it advances to the next remote.

Whole patch (server + client) has been merged to master and will be part of 2.4.

---
 src/openvpn/push.c | 7 +++++++
 1 file changed, 7 insertions(+)
src/openvpn/push.c +7 -0
index 11505cb..e4f3984 100644
@@ -103,6 +103,7 @@ server_pushed_signal (struct context *c, const struct buffer *buffer, const bool
 	m = BSTR (&buf);
 
       /* preserve cached passwords? */
+      /* advance to next server? */
       {
 	bool purge = true;
 
@@ -113,6 +114,12 @@ server_pushed_signal (struct context *c, const struct buffer *buffer, const bool
 	      {
 		if (m[i] == 'P')
 		  purge = false;
+		else if (m[i] == 'N')
+		  {
+		    /* next server? */
+		    if (c->options.connection_list)
+		      c->options.connection_list->no_advance = false;
+		  }
 	      }
 	  }
 	if (purge)
Signature · 1 line
1.9.1
#1 lore raw

Am 23.11.15 um 12:38 schrieb Lev Stipakov:

Quoted 5 lines

When client receives "RESTART,N", it advances to the next remote.

Whole patch (server + client) has been merged to master and will be part of 2.4.

ACK, based on same code as in 2.4 and is very small and non intrusive.

Arne

#2 lore raw
In reply to Lev Stipakov

Your patch has been applied to the release/2.3 branch.

commit 983f01861c31b3d768ec9b119cd26f8d1f2f7a73

Author: Lev Stipakov
Date:   Mon Nov 23 13:38:13 2015 +0200
     Client-side part for server restart notification

     Signed-off-by: Lev Stipakov <[email protected]...>
     Acked-by: Arne Schwabe <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/10564
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering