Skip to contentSkip to conversation

remove unused gc_arena in FreeBSD close_tun()

PATCH In review Gert Doering 2 participants 3 messages Nov 24, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove unused gc_arena in FreeBSD close_tun()

not used, and a small mem leak on every tunnel close...

---
 src/openvpn/tun.c | 1 -
 1 file changed, 1 deletion(-)
src/openvpn/tun.c +0 -1
index 8139afc..c293e1e 100644
@@ -2539,7 +2539,6 @@ close_tun (struct tuntap *tt)
     }
   else if (tt)				/* close and destroy */
     {
-      struct gc_arena gc = gc_new ();
       struct argv argv;
 
       /* setup command, close tun dev (clears tt->actual_name!), run command
Signature · 1 line
2.6.2
#1 lore raw
Quoted 13 lines · Gert Doering

not used, and a small mem leak on every tunnel close...

---
 src/openvpn/tun.c | 1 -
 1 file changed, 1 deletion(-)
src/openvpn/tun.c +0 -0
index 8139afc..c293e1e 100644

src/openvpn/tun.c close_tun (struct tuntap *tt) · line 2544

Quoted 7 lines
src/openvpn/tun.c +0 -1
@@ -2539,7 +2539,6 @@ close_tun (struct tuntap *tt)
     }
   else if (tt)				/* close and destroy */
     {
-      struct gc_arena gc = gc_new ();
       struct argv argv;
 
       /* setup command, close tun dev (clears tt->actual_name!), run command

ACK

-Steffan

#2 lore raw
In reply to Gert Doering

Patch has been applied to the master and release/2.3 branch.

commit cef57449b98c38deb35e885bd8958fe09f6a2b02 (master) commit 5731a570c4f089371578445f6deadfb4189f3e9e (release/2.3)

Author: Gert Doering
Date:   Tue Nov 24 14:09:10 2015 +0100
     remove unused gc_arena in FreeBSD close_tun()

     Signed-off-by: Gert Doering <[email protected]...>
     Acked-by: Steffan Karger <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/10581

--
kind regards,

Gert Doering