remove nonsense const specifier in nonfatal() return value
PATCH 1/1 remove nonsense const specifier in nonfatal() return value
From: Steffan Karger <[email protected]...>
Return values are rvalues, and can not be changed anyway. Adding const does not make sense here at all. (What was I thinking...?)
Signed-off-by Steffan Karger <[email protected]...>
--- src/openvpn/error.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/error.h +1 -1
@@ -353,7 +353,7 @@ ignore_sys_error (const int err) }/** Convert fatal errors to nonfatal, don't touch other errors */ -static inline const unsigned int +static inline unsigned int nonfatal (const unsigned int err) {return err &M_FATAL ? (err ^M_FATAL ) |M_NONFATAL : err; }
Signature · 1 line
2.1.4
ACK. Your patch has been applied to the master branch.
commit f544e388527066dcf17ea0e257b9182a7286e821
Author: Steffan Karger Date: Tue Nov 24 15:00:35 2015 +0100
remove nonsense const specifier in nonfatal() return value
Signed-off-by: Steffan Karger <[email protected]...>
Acked-by: Gert Doering <[email protected]...>
Message-Id: <[email protected]...>
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering