fat: Allow time_offset to be upto 24 hours
Subsystems (2)
Jan Kara
reviewerPATCH 1/1 fat: Allow time_offset to be upto 24 hours
Currently we limit values of time_offset mount option to be between -12 and 12 hours. However e.g. zone GMT+12 can have a DST correction on top which makes the total time difference 13 hours. Update the checks in mount option parsing to allow offset of upto 24 hours to allow for unusual cases.
Reported-by Volker Kuhlmann <[email protected]>
Signed-off-by Jan Kara <[email protected]>
--- fs/fat/inode.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
fs/fat/inode.c +6 -1
@@ -1146,7 +1146,12 @@ static int parse_options(struct super_block *sb, char *options, int is_vfat,case Opt_time_offset:if (match_int (&args[0 ], &option))return -EINVAL ; -if (option <-12 *60 || option >12 *60 ) +/* +* GMT+-12 zones may have DST corrections so at least +* 13 hours difference is needed. Make the limit 24 +* just in case someone invents something unusual. +*/ +if (option <-24 *60 || option >24 *60 )return -EINVAL ; opts->tz_set =1 ; opts->time_offset = option;
Signature · 1 line
2.1.4
Quoted 8 lines · Jan Kara
Currently we limit values of
time_offsetmount option to be between -12 and 12 hours. However e.g. zone GMT+12 can have a DST correction on top which makes the total time difference 13 hours. Update the checks in mount option parsing to allow offset of upto 24 hours to allow for unusual cases.Reported-by Volker Kuhlmann <[email protected]>Signed-off-by Jan Kara <[email protected]>
Acked-by OGAWA Hirofumi <[email protected]>
Thanks.
Quoted 22 lines
--- fs/fat/inode.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)fs/fat/inode.c +6
-1@@ -1146,7 +1146,12 @@ static int parse_options(struct super_block *sb, char *options, int is_vfat,case Opt_time_offset:if (match_int (&args[0 ], &option))return -EINVAL ; -if (option <-12 *60 || option >12 *60 ) +/* +* GMT+-12 zones may have DST corrections so at least +* 13 hours difference is needed. Make the limit 24 +* just in case someone invents something unusual. +*/ +if (option <-24 *60 || option >24 *60 )return -EINVAL ; opts->tz_set =1 ; opts->time_offset = option;
Signature · 1 line
OGAWA Hirofumi <[email protected]>