Skip to contentSkip to conversation

patches: fix path in name_assign_type patch

PATCH In review Arend van Spriel 3 participants 9 messages Nov 30, 2015 – Dec 9, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 patches: fix path in name_assign_type patch

Patch for brcmfmac need update path as it now resides under the broadcom vendor directory.

---
 .../network/0055-name_assign_type/brcmfmac.patch                      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch +2 -2
index c68e9d0..bcbac24 100644
@@ -1,5 +1,5 @@
---- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
-+++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
+--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
 @@ -2204,7 +2204,9 @@ struct wireless_dev *brcmf_p2p_add_vif(s
  	}
  
Signature · 4 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe backports" in
#1 lore raw
Quoted 14 lines · Arend van Spriel

Patch for brcmfmac need update path as it now resides under the broadcom vendor directory.

---
 .../network/0055-name_assign_type/brcmfmac.patch                      | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch +0 -0
index c68e9d0..bcbac24 100644

patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch line 5

Quoted 7 lines
patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch +2 -2
@@ -1,5 +1,5 @@
---- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
-+++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
+--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
 @@ -2204,7 +2204,9 @@ struct wireless_dev *brcmf_p2p_add_vif(s
  	}
 

I will do this for all patches at once, but thanks.

Is it ok to replace the b43, b43legacy and brcm80211 by this single line? drivers/net/wireless/broadcom/

Hauke
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#2 lore raw
Quoted 5 lines

Is it ok to replace the b43, b43legacy and brcm80211 by this single line?
drivers/net/wireless/broadcom/

You mean in a single patch? I generally considered each file (or at least driver) separately so you could restrict copy-list to it.

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#3 lore raw
Quoted 8 lines · Johannes Berg
Quoted 5 lines

Is it ok to replace the b43, b43legacy and brcm80211 by this single line?
drivers/net/wireless/broadcom/

You mean in a single patch? I generally considered each file (or at least driver) separately so you could restrict copy-list to it.

There is option to do:

drivers/net/wireless/broadcom/Kconfig
drivers/net/wireless/broadcom/Makefile
drivers/net/wireless/broadcom/b43
drivers/net/wireless/broadcom/b43legacy
drivers/net/wireless/broadcom/brcm80211

Or (as Hauke suggests):

drivers/net/wireless/broadcom/

To restrict the copy-list the first option would be preferred.

Regards,
Arend

Quoted 4 lines

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

--
To unsubscribe from this list: send the line "unsubscribe backports" in

#4 lore raw
Quoted 9 lines · Arend van Spriel

Quoted 1 line
Quoted 1 line

drivers/net/wireless/broadcom/

drivers/net/wireless/broadcom/Kconfig
drivers/net/wireless/broadcom/Makefile
drivers/net/wireless/broadcom/b43
drivers/net/wireless/broadcom/b43legacy
drivers/net/wireless/broadcom/brcm80211

Quoted 6 lines

Or (as Hauke suggests):

drivers/net/wireless/broadcom/

To restrict the copy-list the first option would be preferred.

Oh, you meant for the copy-list?

I thought upstream backports just shipped a single copy-list line "ddrivers/net/wireless/"?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#5 lore raw
Quoted 14 lines · Johannes Berg
Quoted 13 lines · Arend van Spriel
Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/broadcom/

drivers/net/wireless/broadcom/Kconfig
drivers/net/wireless/broadcom/Makefile
drivers/net/wireless/broadcom/b43
drivers/net/wireless/broadcom/b43legacy
drivers/net/wireless/broadcom/brcm80211

Or (as Hauke suggests):

drivers/net/wireless/broadcom/

Quoted 7 lines
Quoted 2 lines

To restrict the copy-list the first option would be preferred.

Oh, you meant for the copy-list?

I thought upstream backports just shipped a single copy-list line "ddrivers/net/wireless/"?

Nope. It is:

# 802.11
drivers/net/wireless/Kconfig
drivers/net/wireless/Makefile

It looks for subfolders and modifies the Kconfig and Makefile for the ones missing (comment out).

Regards,
Arend

Quoted 2 lines

johannes

--
To unsubscribe from this list: send the line "unsubscribe backports" in

#6 lore raw
Quoted 29 lines · Arend van Spriel
Quoted 14 lines · Johannes Berg
Quoted 13 lines · Arend van Spriel
Quoted 2 lines
Quoted 2 lines

drivers/net/wireless/broadcom/

drivers/net/wireless/broadcom/Kconfig
drivers/net/wireless/broadcom/Makefile
drivers/net/wireless/broadcom/b43
drivers/net/wireless/broadcom/b43legacy
drivers/net/wireless/broadcom/brcm80211

Or (as Hauke suggests):

drivers/net/wireless/broadcom/

Quoted 7 lines
Quoted 2 lines

To restrict the copy-list the first option would be preferred.

Oh, you meant for the copy-list?

I thought upstream backports just shipped a single copy-list line "ddrivers/net/wireless/"?

Nope. It is:

# 802.11
drivers/net/wireless/Kconfig
drivers/net/wireless/Makefile

Quoted 8 lines

It looks for subfolders and modifies the Kconfig and Makefile for the ones missing (comment out).

Regards,
Arend

Quoted 2 lines

johannes

Arend is right I was asking if you would like:
drivers/net/wireless/broadcom/Kconfig
drivers/net/wireless/broadcom/Makefile
drivers/net/wireless/broadcom/b43
drivers/net/wireless/broadcom/b43legacy
drivers/net/wireless/broadcom/brcm80211

or this:
drivers/net/wireless/broadcom/

or this:
drivers/net/wireless/

for the copy-list file.

This is not just about the Broadcom driver I would do it in the same way for all wifi driver.

Do both of you replace the copy-list file in your internal versions?

Hauke
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#7 lore raw
Quoted 3 lines · Hauke Mehrtens


Do both of you replace the copy-list file in your internal versions?

I think Arend said he did, and I certainly do that too. I actually just have my own and run the gentree/git-tracker scripts with the right commandline parameter.

So I think

drivers/net/wireless/

makes most sense since that requires no maintenance?

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

#8 lore raw
In reply to Hauke Mehrtens
Quoted 24 lines · Hauke Mehrtens
Quoted 14 lines · Arend van Spriel

Patch for brcmfmac need update path as it now resides under the broadcom vendor directory.

---
  .../network/0055-name_assign_type/brcmfmac.patch                      | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch +0 -0
index c68e9d0..bcbac24 100644

patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch line 5

Quoted 7 lines
patches/collateral-evolutions/network/0055-name_assign_type/brcmfmac.patch +2 -2
@@ -1,5 +1,5 @@
---- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
-+++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c
+--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
++++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c
  @@ -2204,7 +2204,9 @@ struct wireless_dev *brcmf_p2p_add_vif(s
   	}
 

I will do this for all patches at once, but thanks.

Quoted 2 lines

Is it ok to replace the b43, b43legacy and brcm80211 by this single line? drivers/net/wireless/broadcom/

Fine by me. I have my own copy-list to only deal with brcm80211.

Regards,
Arend

Quoted 4 lines

Hauke
--
To unsubscribe from this list: send the line "unsubscribe backports" in

--
To unsubscribe from this list: send the line "unsubscribe backports" in