Skip to contentSkip to conversation

sf: Remove #ifdef #endif in Makefile

PATCH New Bin Meng 2 participants 3 messages Dec 1, 2015 – Dec 3, 2015 Memory technology devices (MTD)

lore
Share & tools
lore

Bin Meng

author
#0 lore raw

PATCH 1/1 sf: Remove #ifdef #endif in Makefile

The #ifdef #endif in drivers/mtd/spi/Makefile actually does nothing but causes confusion. Remove it.

---

 drivers/mtd/spi/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/mtd/spi/Makefile +0 -2
index cf4e7e1..6ca1b72 100644
@@ -12,9 +12,7 @@ obj-$(CONFIG_SPL_SPI_LOAD)	+= spi_spl_load.o
 obj-$(CONFIG_SPL_SPI_BOOT)	+= fsl_espi_spl.o
 endif
 
-#ifndef CONFIG_DM_SPI
 obj-$(CONFIG_SPI_FLASH) += sf_probe.o
-#endif
 obj-$(CONFIG_CMD_SF) += sf.o
 obj-$(CONFIG_SPI_FLASH) += sf_ops.o sf_params.o
 obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o
Signature · 1 line
1.8.2.1
#1 lore raw

PATCH 1/1 sf: Remove #ifdef #endif in Makefile

Hi Bin,

Quoted 14 lines · Bin Meng

The #ifdef #endif in drivers/mtd/spi/Makefile actually does nothing but causes confusion. Remove it.

---

 drivers/mtd/spi/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/mtd/spi/Makefile +0 -0
index cf4e7e1..6ca1b72 100644

drivers/mtd/spi/Makefile obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o · line 18

Quoted 9 lines
drivers/mtd/spi/Makefile +0 -2
@@ -12,9 +12,7 @@ obj-$(CONFIG_SPL_SPI_LOAD)    += spi_spl_load.o
 obj-$(CONFIG_SPL_SPI_BOOT)     += fsl_espi_spl.o
 endif
 
-#ifndef CONFIG_DM_SPI
 obj-$(CONFIG_SPI_FLASH) += sf_probe.o
-#endif
 obj-$(CONFIG_CMD_SF) += sf.o
 obj-$(CONFIG_SPI_FLASH) += sf_ops.o sf_params.o
 obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o

Sent similar change on this [1] patch

[1] https://patchwork.ozlabs.org/patch/549041/

thanks!

Signature · 1 line
Jagan .
author
#2 lore raw

PATCH 1/1 sf: Remove #ifdef #endif in Makefile

Hi Jagan,

Quoted 29 lines · Jagan Teki

Hi Bin,

Quoted 14 lines · Bin Meng

The #ifdef #endif in drivers/mtd/spi/Makefile actually does nothing but causes confusion. Remove it.

---

 drivers/mtd/spi/Makefile | 2 --
 1 file changed, 2 deletions(-)
drivers/mtd/spi/Makefile +0 -0
index cf4e7e1..6ca1b72 100644

drivers/mtd/spi/Makefile obj-$(CONFIG_SPL_SPI_LOAD) += spi_spl_load.o · line 18

Quoted 9 lines
drivers/mtd/spi/Makefile +0 -2
@@ -12,9 +12,7 @@ obj-$(CONFIG_SPL_SPI_LOAD)    += spi_spl_load.o
 obj-$(CONFIG_SPL_SPI_BOOT)     += fsl_espi_spl.o
 endif
 
-#ifndef CONFIG_DM_SPI
 obj-$(CONFIG_SPI_FLASH) += sf_probe.o
-#endif
 obj-$(CONFIG_CMD_SF) += sf.o
 obj-$(CONFIG_SPI_FLASH) += sf_ops.o sf_params.o
 obj-$(CONFIG_SPI_FLASH_DATAFLASH) += sf_dataflash.o

Sent similar change on this [1] patch

Quoted 2 lines

[1] https://patchwork.ozlabs.org/patch/549041/

Ah, yes! Thanks.

Quoted 2 lines

thanks!
--

Regards,
Bin