Skip to contentSkip to conversation

ia64: bitvector_process could read out of bounds

PATCH New Geyslan G. Bem 1 participant 1 message Dec 2, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ia64: bitvector_process could read out of bounds

The units[] array could be accessed out of its bounds due the lack of verification of the max vector value.

To make this function not prone to error "P" and "E" suffixes were added. Despite the new suffixes are unrelated to current ia64 vm magnitudes, they make the code ready for it and avoid misleadings.

Caught using static analysis (cppcheck).

---
 arch/ia64/kernel/palinfo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/ia64/kernel/palinfo.c +1 -1
index c39c3cd..bb499102 100644
@@ -126,7 +126,7 @@ static const char *mem_attrib[]={
 static void bitvector_process(struct seq_file *m, u64 vector)
 {
 	int i,j;
-	static const char *units[]={ "", "K", "M", "G", "T" };
+	static const char *units[] = { "", "K", "M", "G", "T", "P", "E" };
 
 	for (i=0, j=0; i < 64; i++ , j=i/10) {
 		if (vector & 0x1)
Signature · 1 line
2.6.2