ARC: [axs10x] enable DW DMA controller
PATCH 1/1 ARC: [axs10x] enable DW DMA controller
From: Nelson Pereira <[email protected]>
ARC SDP baseboard among other peripherals sports
DesignWare DMA controller.
This enables support of that device.
Note typically DW DMA controller is used with external devices connected to ARC SDP board via HAPS Extension bus.
--- arch/arc/boot/dts/axs10x_mb.dtsi | 16 ++++++++++++++++ arch/arc/configs/axs101_defconfig | 5 +++++ arch/arc/configs/axs103_defconfig | 5 +++++ arch/arc/configs/axs103_smp_defconfig | 5 +++++ 4 files changed, 31 insertions(+)
arch/arc/boot/dts/axs10x_mb.dtsi +16 -0
@@ -220,5 +220,21 @@ reg = <2>; }; }; + + dmac: dmac at 0x80000 { + compatible = "snps,dma-spear1340"; + reg = <0x80000 0x1000>; + interrupts = <9>; + dma-channels = <4>; + dma-requests = <16>; + dma-masters = <2>; + #dma-cells = <3>; + chan_allocation_order = <1>; + chan_priority = <1>; + block_size = <0xfff>; + data_width = <3 3>; + clocks = <&apbclk>; + clock-names = "hclk"; + }; }; };
arch/arc/configs/axs101_defconfig +5 -0
@@ -90,6 +90,11 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y +CONFIG_DMADEVICES=y +CONFIG_DW_DMAC_CORE=y +CONFIG_DW_DMAC=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_OF=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT3_FS=y CONFIG_EXT4_FS=y
arch/arc/configs/axs103_defconfig +5 -0
@@ -96,6 +96,11 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y +CONFIG_DMADEVICES=y +CONFIG_DW_DMAC_CORE=y +CONFIG_DW_DMAC=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_OF=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT3_FS=y CONFIG_EXT4_FS=y
arch/arc/configs/axs103_smp_defconfig +5 -0
@@ -97,6 +97,11 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y +CONFIG_DMADEVICES=y +CONFIG_DW_DMAC_CORE=y +CONFIG_DW_DMAC=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_OF=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT3_FS=y CONFIG_EXT4_FS=y
Signature · 1 line
2.4.3
Quoted 8 lines · Alexey Brodkin
From: Nelson Pereira <npereira at synopsys.com>
ARC SDP baseboard among other peripherals sports
DesignWare DMA controller.This enables support of that device.
Note typically DW DMA controller is used with external devices connected to ARC SDP board via HAPS Extension bus.
Such a board config needs to have it's own defconfig / DT (if needed). There's no point in enabling this for rest of the world who don't have a use case for this IP.
So nack !
-Vineet
Quoted 85 lines
Signed-off-by Nelson Pereira <npereira at synopsys.com>Cc Vineet Gupta <vgupta at synopsys.com>Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>--- arch/arc/boot/dts/axs10x_mb.dtsi | 16 ++++++++++++++++ arch/arc/configs/axs101_defconfig | 5 +++++ arch/arc/configs/axs103_defconfig | 5 +++++ arch/arc/configs/axs103_smp_defconfig | 5 +++++ 4 files changed, 31 insertions(+)arch/arc/boot/dts/axs10x_mb.dtsi +16
-0@@ -220,5 +220,21 @@ reg = <2>; }; }; + + dmac: dmac at 0x80000 { + compatible = "snps,dma-spear1340"; + reg = <0x80000 0x1000>; + interrupts = <9>; + dma-channels = <4>; + dma-requests = <16>; + dma-masters = <2>; + #dma-cells = <3>; + chan_allocation_order = <1>; + chan_priority = <1>; + block_size = <0xfff>; + data_width = <3 3>; + clocks = <&apbclk>; + clock-names = "hclk"; + }; }; };arch/arc/configs/axs101_defconfig +5
-0@@ -90,6 +90,11 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y +CONFIG_DMADEVICES=y +CONFIG_DW_DMAC_CORE=y +CONFIG_DW_DMAC=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_OF=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT3_FS=y CONFIG_EXT4_FS=yarch/arc/configs/axs103_defconfig +5
-0@@ -96,6 +96,11 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y +CONFIG_DMADEVICES=y +CONFIG_DW_DMAC_CORE=y +CONFIG_DW_DMAC=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_OF=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT3_FS=y CONFIG_EXT4_FS=yarch/arc/configs/axs103_smp_defconfig +5
-0@@ -97,6 +97,11 @@ CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_PLTFM=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y +CONFIG_DMADEVICES=y +CONFIG_DW_DMAC_CORE=y +CONFIG_DW_DMAC=y +CONFIG_DMA_ENGINE=y +CONFIG_DMA_OF=y # CONFIG_IOMMU_SUPPORT is not set CONFIG_EXT3_FS=y CONFIG_EXT4_FS=y
Hi Vineet,
Quoted 6 lines · Vineet Gupta
Quoted 5 lines · Alexey Brodkin
From: Nelson Pereira <npereira at synopsys.com>
ARC SDP baseboard among other peripherals sports
DesignWare DMA controller.
Quoted 8 lines
Quoted 3 lines
This enables support of that device.
Note typically DW DMA controller is used with external devices connected to ARC SDP board via HAPS Extension bus.Such a board config needs to have it's own defconfig / DT (if needed). There's no point in enabling this for rest of the world who don't have a use case for this IP.
So nack !
I see rationale behind this decision but:
1) How enabled DMA controller hurts other users of the same SDP board
2) That DMA controller exists in SDP anyway - that's not a special flavor of ARC SDP
3) Another defconfig and .dts adds another item for verification while enabling DW DMA in our current defconfigs allows usage of the same one binaries for all purposes on ARC SDP.
-Alexey