Skip to contentSkip to conversation

selinux: use absolute path to include directory

PATCH Paul Moore 2 participants 3 messages Jan 19, 2016 1 message not in the archive SELinux security module

lore
Share & tools
lore

Paul Moore

author maintainer
#1 lore raw
In reply to a message not in the archive
Quoted 21 lines · Andy Shevchenko

Compiler warns us a lot that it can't find include folder because it's provided in relative form.

CC security/selinux/netlabel.o
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]

Add $(srctree) prefix to the path.

---
 security/selinux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/Makefile +0 -0
index ad5cd76..90d1adb 100644

security/selinux/Makefile selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o · line 16

Quoted 5 lines
security/selinux/Makefile +1 -1
@@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
 
 selinux-$(CONFIG_NETLABEL) += netlabel.o
 
-ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
+ccflags-y := -Isecurity/selinux -I$(srctree)/security/selinux/include

Why not add the $(srctree) prefix to both paths?

Quoted 5 lines
security/selinux/Makefile +0 -1
 $(addprefix $(obj)/,$(selinux-y)): $(obj)/flask.h
 
--

2.6.2

Signature · 2 lines
paul moore
www.paul-moore.com
#2 lore raw
Quoted 29 lines · Paul Moore
Quoted 27 lines · Andy Shevchenko

Compiler warns us a lot that it can't find include folder because it's provided
in relative form.

  CC      security/selinux/netlabel.o
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]

Add $(srctree) prefix to the path.

---
 security/selinux/Makefile | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/Makefile +0 -0
index ad5cd76..90d1adb 100644
@@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
 
Quoted 7 lines

security/selinux/Makefile

Quoted 5 lines

 selinux-$(CONFIG_NETLABEL) += netlabel.o

security/selinux/Makefile +1 -2
-ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
+ccflags-y := -Isecurity/selinux
-I$(srctree)/security/selinux/include

Why not add the $(srctree) prefix to both paths?

I don't care as long as it fixes the annoying messages. Though, I can re-do the patch if it looks better that way.

Signature · 2 lines
Andy Shevchenko <[email protected]>
Intel Finland Oy
author maintainer
#3 lore raw
Quoted 32 lines · Andy Shevchenko
Quoted 31 lines · Paul Moore
Quoted 29 lines · Andy Shevchenko

Compiler warns us a lot that it can't find include folder because it's provided
in relative form.

CC security/selinux/netlabel.o
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]
cc1: warning: security/selinux/include: No such file or directory [-Wmissing-include-dirs]

Add $(srctree) prefix to the path.

---
 security/selinux/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
security/selinux/Makefile +0 -0
index ad5cd76..90d1adb 100644
@@ -13,7 +13,7 @@ selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
 
 selinux-$(CONFIG_NETLABEL) += netlabel.o
 
Quoted 8 lines
Quoted 5 lines

security/selinux/Makefile selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o · line 17

Quoted 3 lines
security/selinux/Makefile +1 -2
-ccflags-y := -Isecurity/selinux -Isecurity/selinux/include
+ccflags-y := -Isecurity/selinux
-I$(srctree)/security/selinux/include

Why not add the $(srctree) prefix to both paths?

I don't care as long as it fixes the annoying messages. Though, I can re-do the patch if it looks better that way.

Please do.

Signature · 2 lines
paul moore
www.paul-moore.com