Skip to contentSkip to conversation

Patch "mwifiex: avoid memsetting PCIe event buffer" has been added to the 4.3-stable tree

PATCH [email protected] 1 participant 1 message Dec 7, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

mwifiex: avoid memsetting PCIe event buffer

to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
mwifiex-avoid-memsetting-pcie-event-buffer.patch
and it can be found in the queue-4.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 14d9c11c91a606fed65eaae2455423a23bb4ae59 Mon Sep 17 00:00:00 2001

From: Amitkumar Karwar <[email protected]>
Date: Fri, 18 Sep 2015 06:32:10 -0700
Subject: mwifiex: avoid memsetting PCIe event buffer

From: Amitkumar Karwar <[email protected]>

commit 14d9c11c91a606fed65eaae2455423a23bb4ae59 upstream.

Preallocated PCIe buffer is being reused for all PCIe interface events. Physical address of the buffer is shared with firmware so that it can perform DMA on it. As event length is specified in the header, there should not be a problem if the buffer gets overwritten.
We will save some cycles by avoiding memset everytime while submitting the buffer to firmware.

Fixes 2728cecdc7d6bf3d21(mwifiex: corrections in PCIe event skb)
---
 drivers/net/wireless/mwifiex/pcie.c |    1 -
 1 file changed, 1 deletion(-)
drivers/net/wireless/mwifiex/pcie.c +0 -1
@@ -1815,7 +1815,6 @@ static int mwifiex_pcie_event_complete(s
 	if (!card->evt_buf_list[rdptr]) {
 		skb_push(skb, INTF_HEADER_LEN);
 		skb_put(skb, MAX_EVENT_SIZE - skb->len);
-		memset(skb->data, 0, MAX_EVENT_SIZE);
 		if (mwifiex_map_pci_memory(adapter, skb,
 					   MAX_EVENT_SIZE,
 					   PCI_DMA_FROMDEVICE))

Patches currently in stable-queue which might be from [email protected] are

queue-4.3/mwifiex-avoid-memsetting-pcie-event-buffer.patch queue-4.3/mwifiex-fix-null-pointer-dereference-during-hidden-ssid-scan.patch queue-4.3/mwifiex-fix-mwifiex_rdeeprom_read.patch