Skip to contentSkip to conversation

Patch "s390/pci: reshuffle struct used to write debug data" has been added to the 4.3-stable tree

PATCH [email protected] 1 participant 1 message Dec 7, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

s390/pci: reshuffle struct used to write debug data

to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
s390-pci-reshuffle-struct-used-to-write-debug-data.patch
and it can be found in the queue-4.3 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7cc8944e13c73374b6f33b39ca24c0891c87b077 Mon Sep 17 00:00:00 2001

From: Sebastian Ott <[email protected]>
Date: Fri, 9 Oct 2015 11:07:06 +0200
Subject: s390/pci: reshuffle struct used to write debug data

From: Sebastian Ott <[email protected]>

commit 7cc8944e13c73374b6f33b39ca24c0891c87b077 upstream.

zpci_err_insn writes stale stack content to the debugfs.

Ensure that the struct in zpci_err_insn is ordered in a way that we don't have uninitialized holes in it. In addition to that add the packed attribute.

Fixes 3d8258e (s390/pci: move debug messages to debugfs)
---
 arch/s390/pci/pci_insn.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/s390/pci/pci_insn.c +3 -3
@@ -16,11 +16,11 @@
 static inline void zpci_err_insn(u8 cc, u8 status, u64 req, u64 offset)
 {
 	struct {
-		u8 cc;
-		u8 status;
 		u64 req;
 		u64 offset;
-	} data = {cc, status, req, offset};
+		u8 cc;
+		u8 status;
+	} __packed data = {req, offset, cc, status};
 
 	zpci_err_hex(&data, sizeof(data));
 }

Patches currently in stable-queue which might be from [email protected] are

queue-4.3/s390-pci-reshuffle-struct-used-to-write-debug-data.patch