cifs: Error STATUS_INVALID_OWNER should map to EACCES
Subsystems (2)
PATCH 1/1 cifs: Error STATUS_INVALID_OWNER should map to EACCES
Error STATUS_INVALID_OWNER maps to -EIO. This was encountered when a non priviledged user attempts to change ownership on a file to another user on a share mounted with the cifsacl mount option.
# chown wintest1 a chown: changing ownership of ‘a’: Input/output error
The error returned is confusing for users who do not expect this error. The proposal is to return -EACCES instead when a STATUS_INVALID_OWNER is returned.
--- fs/cifs/netmisc.c | 2 +- fs/cifs/smb2maperror.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
fs/cifs/netmisc.c +1 -1
@@ -324,7 +324,7 @@ static const struct { ERRDOS, ERRunsup, NT_STATUS_CTL_FILE_NOT_SUPPORTED}, { ERRHRD, ERRgeneral, NT_STATUS_UNKNOWN_REVISION}, { ERRHRD, ERRgeneral, NT_STATUS_REVISION_MISMATCH}, { - ERRHRD, ERRgeneral, NT_STATUS_INVALID_OWNER}, { + ERRDOS, ERRnoaccess, NT_STATUS_INVALID_OWNER}, { ERRHRD, ERRgeneral, NT_STATUS_INVALID_PRIMARY_GROUP}, { ERRHRD, ERRgeneral, NT_STATUS_NO_IMPERSONATION_TOKEN}, { ERRHRD, ERRgeneral, NT_STATUS_CANT_DISABLE_MANDATORY}, {
fs/cifs/smb2maperror.c +1 -1
@@ -384,7 +384,7 @@ static const struct status_to_posix_error smb2_error_map_table[] = { "STATUS_CTL_FILE_NOT_SUPPORTED"}, {STATUS_UNKNOWN_REVISION, -EIO, "STATUS_UNKNOWN_REVISION"}, {STATUS_REVISION_MISMATCH, -EIO, "STATUS_REVISION_MISMATCH"}, - {STATUS_INVALID_OWNER, -EIO, "STATUS_INVALID_OWNER"}, + {STATUS_INVALID_OWNER, -EACCES, "STATUS_INVALID_OWNER"}, {STATUS_INVALID_PRIMARY_GROUP, -EIO, "STATUS_INVALID_PRIMARY_GROUP"}, {STATUS_NO_IMPERSONATION_TOKEN, -EIO, "STATUS_NO_IMPERSONATION_TOKEN"}, {STATUS_CANT_DISABLE_MANDATORY, -EIO, "STATUS_CANT_DISABLE_MANDATORY"},
Signature · 1 line
2.4.3
A message that is not in the archive (sent off-list or not yet received): 1449575977-9783-1-git-send-email-sprabhu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Quoted 8 lines · Sachin Prabhu
Error
STATUS_INVALID_OWNERmaps to-EIO. This was encountered when a non priviledged user attempts to change ownership on a file to another
user on a share mounted with the cifsacl mount option.# chown wintest1 a chown: changing ownership of ‘a’: Input/output error
Quoted 7 lines
The error returned is confusing for users who do not expect this error.
The proposal is to return-EACCESinstead when aSTATUS_INVALID_OWNERis
returned.Signed-off-by Sachin Prabhu <[email protected]>
Maybe EINVAL may be better in this case. Steve/Sirish, do you have any advise on how we should proceed with this?
Sachin Prabhu
Quoted 36 lines
--- fs/cifs/netmisc.c | 2 +- fs/cifs/smb2maperror.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)fs/cifs/netmisc.c +1
-1@@ -324,7 +324,7 @@ static const struct { ERRDOS, ERRunsup, NT_STATUS_CTL_FILE_NOT_SUPPORTED}, { ERRHRD, ERRgeneral, NT_STATUS_UNKNOWN_REVISION}, { ERRHRD, ERRgeneral, NT_STATUS_REVISION_MISMATCH}, { - ERRHRD, ERRgeneral, NT_STATUS_INVALID_OWNER}, { + ERRDOS, ERRnoaccess, NT_STATUS_INVALID_OWNER}, { ERRHRD, ERRgeneral, NT_STATUS_INVALID_PRIMARY_GROUP}, { ERRHRD, ERRgeneral, NT_STATUS_NO_IMPERSONATION_TOKEN}, { ERRHRD, ERRgeneral, NT_STATUS_CANT_DISABLE_MANDATORY}, {fs/cifs/smb2maperror.c +1
-1@@ -384,7 +384,7 @@ static const struct status_to_posix_error smb2_error_map_table[] = { "STATUS_CTL_FILE_NOT_SUPPORTED"}, {STATUS_UNKNOWN_REVISION, -EIO, "STATUS_UNKNOWN_REVISION"}, {STATUS_REVISION_MISMATCH, -EIO, "STATUS_REVISION_MISMATCH"}, - {STATUS_INVALID_OWNER, -EIO, "STATUS_INVALID_OWNER"}, + {STATUS_INVALID_OWNER, -EACCES, "STATUS_INVALID_OWNER"}, {STATUS_INVALID_PRIMARY_GROUP, -EIO,"
STATUS_INVALID_PRIMARY_GROUP"},
{STATUS_NO_IMPERSONATION_TOKEN,-EIO,
"STATUS_NO_IMPERSONATION_TOKEN"},
{STATUS_CANT_DISABLE_MANDATORY,-EIO,
"STATUS_CANT_DISABLE_MANDATORY"},