Skip to contentSkip to conversation

Fix: Use generic irqs_disabled_flags

PATCH Mathieu Desnoyers 1 participant 1 message Dec 10, 2015 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 14 lines · ----- On Dec 9, 2015, at 5:25 PM, Michael Jeanson [email protected] wrote:

instead of arch_irqs_disabled_flags, this fixes the build for kernel < 2.6.37

See linux commit df9ee29270c11dba7d0fe0b83ce47a4d8e8d2101 for more details.

---
wrapper/irqflags.h | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
wrapper/irqflags.h +0 -0
index 77f8382..74c340b 100644

wrapper/irqflags.h int lttng_regs_irqs_disabled(struct pt_regs *regs) · line 36

Quoted 5 lines
wrapper/irqflags.h +1 -1
@@ -33,7 +33,7 @@ int lttng_regs_irqs_disabled(struct pt_regs *regs)
 {
 	unsigned long flags = regs->flags;
 
-	return arch_irqs_disabled_flags(flags);
+	return irqs_disabled_flags(flags);

Can you try with raw_irqs_disabled_flags(flags) instead ?

The non-raw version comes with tracing, and I don't want to invoke tracing from within the tracer, which could cause infinite recursion if this instrumentation gets enabled.

Thanks,

Mathieu

Quoted 5 lines
wrapper/irqflags.h +0 -1
 }
 
 #else
--

1.9.1

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com