Patch "openvswitch: fix hangup on vxlan/gre/geneve device deletion" has been added to the 4.3-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
openvswitch: fix hangup on vxlan/gre/geneve device deletion
to the 4.3-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
openvswitch-fix-hangup-on-vxlan-gre-geneve-device-deletion.patch
and it can be found in the queue-4.3 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Fri Dec 11 11:38:06 EST 2015
From: Paolo Abeni <[email protected]>
Date: Tue, 1 Dec 2015 18:33:36 +0100
Subject: openvswitch: fix hangup on vxlan/gre/geneve device deletion
From: Paolo Abeni <[email protected]>
[ Upstream commit 13175303024c8f4cd09e51079a8fcbbe572111ec ]
Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference to the underlying tunnel device, but never released it when such device is deleted.
Deleting the underlying device via the ip tool cause the kernel to hangup in the netdev_wait_allrefs() loop.
This commit ensure that on device unregistration dp_detach_port_notify() is called for all vports that hold the device reference, properly releasing it.
--- net/openvswitch/dp_notify.c | 2 +- net/openvswitch/vport-netdev.c | 8 ++++++-- 2 files changed, 7 insertions(+), 3 deletions(-)
net/openvswitch/dp_notify.c +1 -1
@@ -58,7 +58,7 @@ void ovs_dp_notify_wq(struct work_structstruct hlist_node *n;hlist_for_each_entry_safe (vport, n, &dp->ports[i], dp_hash_node) { -if (vport->ops->type !=OVS_VPORT_TYPE_NETDEV ) +if (vport->ops->type ==OVS_VPORT_TYPE_INTERNAL )continue ;if (!(vport->dev->priv_flags &IFF_OVS_DATAPATH ))
net/openvswitch/vport-netdev.c +6 -2
@@ -180,9 +180,13 @@ void ovs_netdev_tunnel_destroy(struct vpif (vport->dev->priv_flags &IFF_OVS_DATAPATH )ovs_netdev_detach_dev (vport); -/* Early release so we can unregister the device */ +/* We can be invoked by both explicit vport deletion and +* underlying netdev deregistration; delete the link only +* if it's not already shutting down. +*/ +if (vport->dev->reg_state ==NETREG_REGISTERED ) +rtnl_delete_link (vport->dev);dev_put (vport->dev); -rtnl_delete_link (vport->dev); vport->dev =NULL ;rtnl_unlock ();
Patches currently in stable-queue which might be from [email protected] are
queue-4.3/openvswitch-fix-hangup-on-vxlan-gre-geneve-device-deletion.patch queue-4.3/net-ip6_tunnel-fix-dst-leak.patch