Skip to contentSkip to conversation

Security Working Group - Wednesday March 4

DISCUSSION Joseph Reynolds 1 participant 3 messages Mar 3, 2020 – Apr 24, 2020

lore
Share & tools
lore
#0 lore raw

This is a reminder of the OpenBMC Security Working Group meeting scheduled for this Wednesday March 4 at 10:00am PDT.

We'll discuss current development items, and anything else that comes up.

The current topics:

1. Proposal to add new Redfish roles for ServiceRep & OemRep. 2. Implement the Redfish PasswordChangeRequired property. 3. Proposal to delete BMCWeb sessions after some kinds of account changes.

4. Intel hackathon (pen test, code reviews, etc) results. 5. Security issue: BMCWEB_ENABLE_DBUS_REST=ON enables information leak

6. Discuss making contributions toward https://github.com/openbmc/openbmc/wiki/Security-working-group#security-end-of-release-checklist
for the May 2020 OpenBMC release based on Yocto 3.1.

Access, agenda, and notes are in the wiki:

https://github.com/openbmc/openbmc/wiki/Security-working-group

- Joseph

#1 lore raw
Quoted 6 lines · Joseph Reynolds

This is a reminder of the OpenBMC Security Working Group meeting scheduled for this Wednesday March 4 at 10:00am PDT.

We'll discuss current development items, and anything else that comes up.

The current topics:

Quoted 8 lines

1. Proposal to add new Redfish roles for ServiceRep & OemRep. 2. Implement the Redfish PasswordChangeRequired property. 3. Proposal to delete BMCWeb sessions after some kinds of account changes.

4. Intel hackathon (pen test, code reviews, etc) results. 5. Security issue: BMCWEB_ENABLE_DBUS_REST=ON enables information leak

6. Discuss making contributions toward https://github.com/openbmc/openbmc/wiki/Security-working-group#security-end-of-release-checklist
for the May 2020 OpenBMC release based on Yocto 3.1.

Access, agenda, and notes are in the wiki:

Here is a summary of the discussion.  More details are in the minutes linked below.

1. Weagreed that ServiceRep and ManufacturingRep Privileges are useful to articulate. We found two use cases: Admin same as service agent and manufacturer, and Admin/Service/manufacturer are different roles. Joseph will pursue getting these roles and privileges defined in Redfish. We also discussed the problem of how to prevent the admin from escalating to the Service role given they control User management. (With possible solutions discussed), and some alternate designs. The next step is: Joseph will send an email to the openbmc list with updated details and proposal.

2. Joseph is working on a new D-Bus property for UserPasswordExpired that is needed for BMCWeb.

3. Terminating BMCWeb sessions when there are severe account changes sounds like a good idea. Nobody signed up to work on it. :)

4. James asked about how to report security vulnerabilities.  The plan to is to follow
https://github.com/openbmc/docs/blob/master/security/how-to-report-a-security-vulnerability.md
and make a judgment call, sending some to the email list (thus disclosing them) and some to the OpenBMC security response team. The response team can then sort out which issues can be disclosed, and which we want to fix.
That will be a good stress test.

5. We want definite plans and a timeline for changing the default to BMCWEB_ENABLE_DBUS_REST=OFF.

6. Joseph will propose an OpenBMC-customized dynamic-security-scan tool via email.

- Joseph

Quoted 5 lines

https://github.com/openbmc/openbmc/wiki/Security-working-group

- Joseph

#2 lore raw

Re: Security Working Group - Wednesday March 4 - PasswordChangeRequired ready for function test

Quoted 13 lines · Joseph Reynolds
Quoted 9 lines · Joseph Reynolds

This is a reminder of the OpenBMC Security Working Group meeting scheduled for this Wednesday March 4 at 10:00am PDT.

We'll discuss current development items, and anything else that comes up.

The current topics:

1. Proposal to add new Redfish roles for ServiceRep & OemRep. 2. Implement the Redfish PasswordChangeRequired property. 3. Proposal to delete BMCWeb sessions after some kinds of account changes.

...snip...

Here is a summary of the discussion.  More details are in the minutes linked below.

Quoted 7 lines

1. Weagreed that ServiceRep and ManufacturingRep Privileges are useful to articulate. We found two use cases: Admin same as service agent and manufacturer, and Admin/Service/manufacturer are different roles. Joseph will pursue getting these roles and privileges defined in Redfish. We also discussed the problem of how to prevent the admin from escalating to the Service role given they control User management. (With possible solutions discussed), and some alternate designs. The next step is: Joseph will send an email to the openbmc list with updated details and proposal.

2. Joseph is working on a new D-Bus property for UserPasswordExpired that is needed for BMCWeb.

3. Terminating BMCWeb sessions when there are severe account changes sounds like a good idea. Nobody signed up to work on it. :)

...snip...

My PasswordChangeRequired code is ready for review.
- This completes all of the planned changes in this area.
- This implements the Redfish ManagerAccount PasswordChangeRequired property.
- This implements dynamic Redfish PasswordChangeRequired handling.

There are three parts:
- BMCWeb: Dynamic PasswordChangeRequired handling:
   https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/29136
- phosphor-user-manager: New User.Attributes UserPasswordExpired property
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-user-manager/+/31449
- phosphor-dbus-interfaces: New User.Attributes UserPasswordExpired property
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/31450

The BMCWeb commit requires (pre-reqs) the User manager commit which then pre-reqs the D-Bus interface commit.

The reason I made this change:
This change makes it possible to default the admin account password to the expired state (so the password must be changed before access to the BMC is granted).  Specifically, this change enables the admin to update their own expired password.  I believe the webui team has plans to implement an "expired password dialog" to do that.  Note that the dynamic Redfish PasswordChangeRequired handling means the user will not need to reestablish a new session after changing their expired password.

- Joseph