Skip to contentSkip to conversation

Updates to Changes.rst

PATCH In review [email protected]... 4 participants 11 messages Dec 15, 2015 – Dec 16, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Updates to Changes.rst

From: Samuli Seppänen <[email protected]...>

This patch is for the release/2.3 branch

---
 Changes.rst | 390 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 383 insertions(+), 7 deletions(-)
Changes.rst +383 -7
index 0188323..38f42b6 100644
@@ -1,24 +1,400 @@
-Version 2.3.9
-=============
-
+Overview of changes in 2.3
+==========================
 
 New features
 ------------
 
-Peer ID support
+Windows DNS leak fix
+    This feature allows blocking all out-of-tunnel communication on TCP/UDP port
+    53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1 and 10.
+
+Client-only support for Peer ID
     Added new packet format P_DATA_V2, which includes peer-id. If
     server and client  support it, client sends all data packets in
     the new format. When data packet arrives, server identifies peer
     by peer-id. If peer's ip/port has changed, server assumes that
     client has floated, verifies HMAC and updates ip/port in internal structs.
+    OpenvPN 2.3.x has client-side functionality only, server needs 2.4.
+
+TLS version negotiation
+    Updated the TLS negotiation logic to adaptively try to connect using
+    the highest TLS version supported by both client and server. The behavior
+    of this feature can be adjusted as necessary.
+
+Push peer info
+    Always push basic set of peer info values to server. This allows the
+    server to make informed choices based on the capabilities of the client.
+    The capabilities include things like supported compression algorithms,
+    SSL library version and GUI version. The amount of data transmitted in peer
+    information can be adjusted.
+
+PolarSSL support
+    Allow use of PolarSSL in OpenVPN as the crypto library, the SSL library and
+    for providing PKCS#11 support.
+
+Plug-in API v3
+    This is a new, more flexible plug-in API.
+
+IPv6 payload and transport support
+    Allow tunneling IPv6 traffic inside an IPv6 tunnel, as well as using IPv6
+    as the transport for OpenVPN traffic.
+
+Client-side one-to-one NAT support
+    This feature allows using SNAT or DNAT internally in OpenVPN to work around
+    IP numbering conflicts with pushed routes.
+
+Support for a challenge/response protocol
+    Allows an OpenVPN server to generate challenge questions for the user. This
+    can be used to implement multi-factor authentication. Both dynamic and
+    static challenges are supported.
+
+Improved UTF-8 support
+    OpenVPN can now manage UTF-8 characters, for example in usernames,
+    passwords, X.509 DNs and Windows paths.
+
+Behavioral changes
+------------------
+
+- Remove --enable-password-save option, which was seen as universally useful
+
+- Disallow usage of --server-poll-timeout in --secret key mode
+
+- The second parameter of --ifconfig is no longer a "remote address" but a
+  "netmask" when using --dev tun and --topology subnet
+
+- Automatic TLS version negotiation may cause issues in certain cases.
+
+- Don't exit daemon if opening or parsing the CRL fails
+
+- Do not upcase x509-username-field for mixed-case arguments
+
+- Allow use of connection block variables after connection blocks: this may
+  cause issues in some cases
+
+- Always load intermediate certificates from a PKCS#12 file, instead of ignoring
+  them
+
+- Remove the --disable-eurephia configure option
+
+- Remove the support for using system() when executing external programs or
+  scripts
+
+- Inline files are now always enabled
+
+- Remove the --auto-proxy option
+
+- Directory layout restructuring
+
+- A Windows buildsystem is no longer bundled with OpenVPN 
+
+- Easy-rsa is no longer bundled with OpenVPN
+
+- Tap-windows driver sources are no longer bundled with OpenVPN
+
+- Made some options connection-entry specific
+
+- Make '--win-sys env' default
+
+-  Do not randomize resolving of IP addresses in getaddr()
+
+Version 2.3.9
+=============
+
+New features
+------------
 
-    (2.3.x has client-side functionality only, server needs 2.4)
+- Windows DNS leak fix
 
+- Client-only Peer ID support
 
-User-visible Changes
---------------------
+Behavioral changes
+------------------
 
 - sndbuf and recvbuf default now to OS default instead of 64k
 
 - Removed --enable-password-save from configure. This option is now
   always enabled.
+
+
+Version 2.3.8
+=============
+
+Bug fixes
+---------
+
+- Lots of bug fixes and documentation improvements
+
+Version 2.3.7
+=============
+
+Bug fixes
+---------
+
+- Lots of bug fixes and documentation improvements
+
+New features
+------------
+
+- include ifconfig\_ environment variables in --up-restart env set
+- Re-read auth-user-pass file on (re)connect if required
+
+Behavioral changes
+------------------
+
+- Disallow usage of --server-poll-timeout in --secret key mode
+- Re-enable TLS version negotiation by default
+
+Version 2.3.6
+=============
+
+Bug fixes
+---------
+
+- A few bug fixes and documentation improvement
+
+New features
+------------
+
+- Add client-only support for peer-id
+- Add --tls-version-max
+
+Version 2.3.5
+=============
+
+Bug fixes
+---------
+
+- Fix server routes not working in topology subnet with --server [v3]
+- Fix regression with password protected private keys (polarssl)
+- Fix "code=995" bug with windows NDIS6 tap driver
+- Lots of other bug fixes
+
+Version 2.3.4
+=============
+
+Bug fixes
+---------
+
+- When tls-version-min is unspecified, revert to original versioning approach
+- IPv6 address/route delete fix for Win8
+- Fix SOCKSv5 method selection
+- Lots of other bug fixes and documentation improvements
+
+Version 2.3.3
+=============
+
+Bug fixes
+---------
+
+- Fix slow memory drain on each client renegotiation
+- Fix spurious ignoring of pushed config options (trac#349)
+- Lots of bug fixes and documentation improvements
+
+New features
+------------
+
+- Add reporting of UI version to basic push-peer-info set
+- Add support to ignore specific options
+- Add support of utun devices under Mac OS X
+- Support non-ASCII TAP adapter names on Windows
+- Support non-ASCII characters in Windows tmp path
+- Added "setenv opt" directive prefix
+- --management-external-key for PolarSSL
+- Add support for client-cert-not-required for PolarSSL
+
+Behavioral changes
+------------------
+
+- TLS version negotiation
+- Require polarssl >= 1.2.10 for polarssl-builds, which fixes CVE-2013-5915
+
+Version 2.3.2
+=============
+
+Bug fixes
+---------
+
+- Fix proto tcp6 for server & non-P2MP modes
+- Fix NULL-pointer crash in route_list_add_vpn_gateway()
+- Fix problem with UDP tunneling due to mishandled pktinfo structures
+- Fix segfault when enabling pf plug-ins
+- Lots of other bug fixes
+
+New features
+------------
+
+- Always push basic set of peer info values to server
+- make 'explicit-exit-notify' pullable again
+
+Version 2.3.1
+=============
+
+Bug fixes
+---------
+
+- Repair "tcp server queue overflow" brokenness, more <stdbool.h> fallout
+- Fix directly connected routes for "topology subnet" on Solaris
+- Use constant time memcmp when comparing HMACs in openvpn_decrypt
+- Repair "tcp server queue overflow" brokenness, more <stdbool.h> fallout
+- Lots of other bug fixes and documentation improvements
+
+New features
+------------
+
+- reintroduce --no-name-remapping option
+- make --tls-remote compatible with pre 2.3 configs
+- add new option for X.509 name verification
+- PolarSSL-1.2 support
+- Enable TCP_NODELAY configuration on FreeBSD
+- Permit pool size of /64.../112 for ifconfig-ipv6-pool
+
+Behavioral changes
+------------------
+
+- Switch to IANA names for TLS ciphers
+
+Version 2.3.0
+=============
+
+Bug fixes
+---------
+
+- Fix parameter type for IP_TOS setsockopt on non-Linux systems
+- Fix client crash on double PUSH_REPLY
+
+Version 2.3_rc2
+===============
+
+Bug fixes
+---------
+
+- Fix --show-pkcs11-ids (Bug #239)
+- Lots of other bug fixes and documentation improvements
+
+New features
+------------
+
+- Implement --mssfix handling for IPv6 packets
+
+Version 2.3_rc1
+===============
+
+Bug fixes
+---------
+
+- Fixed a bug where PolarSSL gave an error when using an inline file tag
+- Fix v3 plugins to support returning values back to OpenVPN
+- Lots of other bug fixes and documentation improvements
+
+New features
+------------
+
+- Support UTF-8 --client-config-dir
+
+Behavioral changes
+------------------
+
+- Remove the support for using system() when executing external programs or
+  scripts
+
+Version 2.3_beta1
+=================
+
+Bug fixes
+---------
+
+- Fixes error: --key fails with EXTERNAL_PRIVATE_KEY: No such file or directory 
+  if --management-external-key is used
+- fix regression with --http-proxy[\-\*] options
+- Lots of other bug fixes and documentation improvements
+
+New features
+------------
+
+- Add --compat-names option
+- add API for plug-ins to write to openvpn log
+
+Behavioral changes
+------------------
+
+- Keep pre-existing tun/tap devices around on \*BSD
+
+Version 2.3_alpha3
+==================
+
+Bug fixes
+---------
+
+- Repair "tap server" mode brokenness caused by <stdbool.h> fallout
+- make non-blocking connect work on Windows
+- A few other bug fixes
+
+New features
+------------
+
+- add option --management-query-proxy
+
+Version 2.3_alpha2
+==================
+
+Bug fixes
+---------
+
+- Lots of other bug fixes and documentation improvements
+
+New features
+------------
+
+- Add missing pieces to IPv6 route gateway handling
+
+Behavioral changes
+------------------
+
+- Removed support for PolarSSL < 1.1
+- Complete overhaul of the project structure and the buildsystem
+- remove the --auto-proxy option from openvpn
+
+Version 2.3-alpha1
+==================
+
+Bug fixes
+---------
+
+- Many \*BSD and Windows bug fixes
+- Many Windows installer fixes
+- Properly handle certificate serial numbers > 32 bits
+- Fixed bug in port-share that could cause port share process to crash
+- Fixed issue where a client might receive multiple push replies
+- Lots of other bug fixes and documentation improvements
+
+New features
+------------
+
+- PolarSSL support
+- Add plug-in API v3
+- IPv6 payload and transport support
+- New feauture: Add --stale-routes-check
+- Add support to forward console query to systemd
+- Windows UTF-8 input/output
+- Added "management-external-key" option
+- Added --x509-track option
+- Added "client-nat" option for stateless, one-to-one NAT on the client side
+- Extended "client-kill" management interface command
+- Client will now try to reconnect if no push reply received within
+  handshake-window seconds
+- Added "management-external-key" option
+- Added "auth-token" client directive
+- Added 'dir' flag to "crl-verify"
+- Added support for static challenge/response protocol
+- Changed CC_PRINT character class to allow UTF-8 chars
+- Extend output of "status" management interface command to include usernames
+- Added "memstats" option to maintain real-time operating stats
+- Added support for "on-link" routes on Linux client
+- Add extv3 X509 field support to --x509-username-field
+
+Behavioral changes
+------------------
+
+- Remove support for Linux 2.2
+- Make '--win-sys env' default
+- Remove --enable-osxipconfig configure option
Signature · 1 line
2.1.0
#1 lore raw

Hi
----- Original Message ----- From: <[email protected]...>
To: <[email protected]>
Sent: Tuesday, December 15, 2015 3:00 PM
Subject: [Openvpn-devel] [PATCH] Updates to Changes.rst

Quoted 13 lines

From: Samuli Seppänen <[email protected]...>

This patch is for the release/2.3 branch

+Overview of changes in 2.3
+==========================

New features
------------

Changes.rst +2 -1
-Peer ID support
+Windows DNS leak fix
+    This feature allows blocking all out-of-tunnel communication on 
Quoted 4 lines

TCP/UDP port
+ 53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1
and 10.
+

is WXP no longer supported by git-master ?

Let's call this "idiot proofing" :-)

----- Another Message ----- From: "Fish" <[email protected]...>
To: <[email protected]>
Sent: Monday, December 14, 2015 8:41 PM
Subject: [Openvpn-devel] [PATCH v4] Make "block-outside-dns" option platformagnostic

Quoted 5 lines

Make the "block-outside-dns" option agnostic of Windows versions by dynamically
loading WFP-related functions. Cross-compiled on Linux and tested on Windows
XP/10.

I thought I would give this a shot for WXP but I cannot get it to compile for win32

My system: uname -a
Linux [mint-172-64b] 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

I have watched all the openvpn-dev mailing list and _tried_ to follow all instructions ..
I hope I have just done something stupid ..
like "this does not work for 32bit"
or "you need version X of Y"
or "generic-build system cannot build this version for win32 (yet)" or something like that .. Any help or pointers welcome.

Any clarity on what to expect of the --block-outside-dns option and what windows version it is/will be support would help.

Thanks

What I did:
===
sudo apt-get update & upgrade
Using generic build system (which successfully built openvpn-build.git today
using: IMAGEROOT=pwd/image-win32 CHOST=i686-w64-mingw32 \
CBUILD=x86_64-pc-linux-gnu ./build)

Log:
---
Tue Dec 15 14:18:35 2015 us=45270 OpenVPN 2.3.6 i686-w64-mingw32 [SSL (OpenSSL)] [LZO] [PKCS11] [IPv6] built on Dec 15 2015
Tue Dec 15 14:18:35 2015 us=45270 library versions: OpenSSL 1.0.1j 15 Oct 2014, LZO 2.08
---

Then I used the build system like so:
===
Cloned:
github.com/OpenVPN/openvpn --to-- generic/sources/openvpn-2.3_git execed:
autoreconf -ivf + ./configure (on that clone)
execed:
tar vzcf openvpn-2.3_git.tar.gz openvpn-2.3_git/*
(rm -rf openvpn-2.3_git)
Removed:
5 other tarballs of normal build,
left openvpn-2.3_git.tar.gz in place.
Changed build.vars:
OPENVPN_VERSION="${OPENVPN_VERSION:-2.3_git}"
execed:
IMAGEROOT=pwd/image-win32 CHOST=i686-w64-mingw32 \
CBUILD=x86_64-pc-linux-gnu ./build)
===

This is log where build broke:
===

i686-w64-mingw32-windres -DHAVE_CONFIG_H -I. -I../.. -I../../include -I../../include -I../../src/compat -DWIN32_LEAN_AND_MEAN -DNTDDI_VERSION=NTDDI_VISTA -D_WIN32_WINNT=_WIN32_WINNT_VISTA -i "openvpn_win32_resources.rc" -o "openvpn_win32_resources.o" mv -f .deps/cryptoapi.Tpo .deps/cryptoapi.Po
In file included from /usr/share/mingw-w64/include/ipsectypes.h:8:0,

                from /usr/share/mingw-w64/include/fwpmtypes.h:9,
                from /usr/share/mingw-w64/include/fwpmu.h:10,
                from win32.c:52:

/usr/share/mingw-w64/include/iketypes.h:747:2: error: #endif without #if #endif /* __iketypes_h__ */
^
In file included from /usr/share/mingw-w64/include/fwpmtypes.h:10:0,

                from /usr/share/mingw-w64/include/fwpmu.h:10,
                from win32.c:52:

/usr/share/mingw-w64/include/iketypes.h:747:2: error: #endif without #if #endif /* __iketypes_h__ */
^
In file included from /usr/share/mingw-w64/include/fwpmu.h:10:0,

                from win32.c:52:
/usr/share/mingw-w64/include/fwpmtypes.h:51:16: error: redefinition of ‘struct FWPM_DISPLAY_DATA0_’
typedef struct FWPM_DISPLAY_DATA0_ {
               ^
In file included from /usr/share/mingw-w64/include/fwpmu.h:9:0,
                from win32.c:52:
/usr/share/mingw-w64/include/fwptypes.h:336:16: note: originally defined here
typedef struct FWPM_DISPLAY_DATA0_ {
               ^
In file included from /usr/share/mingw-w64/include/fwpmu.h:10:0,
                from win32.c:52:

/usr/share/mingw-w64/include/fwpmtypes.h:54:3: error: conflicting types for ‘FWPM_DISPLAY_DATA0’ } FWPM_DISPLAY_DATA0;
^
In file included from /usr/share/mingw-w64/include/fwpmu.h:9:0,

                from win32.c:52:

/usr/share/mingw-w64/include/fwptypes.h:339:3: note: previous declaration of ‘FWPM_DISPLAY_DATA0’ was here } FWPM_DISPLAY_DATA0;
^
In file included from /usr/share/mingw-w64/include/fwpmu.h:11:0,

                from win32.c:52:

/usr/share/mingw-w64/include/iketypes.h:747:2: error: #endif without #if
#endif /* __iketypes_h__ */
^
make[4]: *** [win32.o] Error 1
make[4]: Leaving directory `/home/arby/openvpn-build/20151214-after/generic/tmp/openvpn-2.3_git/src/openvpn' make[3]: *** [install-recursive] Error 1
make[3]: Leaving directory `/home/arby/openvpn-build/20151214-after/generic/tmp/openvpn-2.3_git/src' make[2]: *** [install-recursive] Error 1
make[2]: Leaving directory `/home/arby/openvpn-build/20151214-after/generic/tmp/openvpn-2.3_git' make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/arby/openvpn-build/20151214-after/generic/tmp/openvpn-2.3_git'
make: *** [install-strip] Error 2
FATAL: make openvpn

===

Thanks

#10 lore raw
In reply to [email protected]...

ACK, and thanks for getting this started.

Your patch has been applied to the release/2.3 branch.

(I have added a bit more to it, some of the user-visible changes were missing)

commit 3b1fa7f6ebe5d4bedfe66aac33222e7e1e3e420a

Author: Samuli Seppänen
Date:   Tue Dec 15 17:00:26 2015 +0200
     Updates to Changes.rst

     Signed-off-by: Samuli Seppänen <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: http://article.gmane.org/gmane.network.openvpn.devel/10816
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#2 lore raw
In reply to [email protected]...

Hi,

Quoted 3 lines · On Tue, Dec 15, 2015 at 04:29:21PM -0000, [email protected]... wrote:
Quoted 3 lines

From: Samuli Seppänen <[email protected]...>

This patch is for the release/2.3 branch

[..]

Quoted 9 lines
Quoted 7 lines
Changes.rst +2 -1
-Peer ID support
+Windows DNS leak fix
+    This feature allows blocking all out-of-tunnel communication on 

TCP/UDP port
+ 53 (except for OpenVPN itself), preventing DNS Leaks on Windows 8.1
and 10.
+

is WXP no longer supported by git-master ?

"this patch is for release/2.3 branch" - nobody is talking about master here.

[..]

Quoted 2 lines

I thought I would give this a shot for WXP but I cannot get it to compile for win32

Just use 2.3.9 as will be released in binary tomorrow :-) - but more comments below.

Quoted 2 lines

Any clarity on what to expect of the --block-outside-dns option and what windows version it is/will be support would help.

It will work on Vista+, and give an error on XP.

[..]

Quoted 4 lines
                 from /usr/share/mingw-w64/include/fwpmu.h:10,
                 from win32.c:52:

/usr/share/mingw-w64/include/iketypes.h:747:2: error: #endif without #if
#endif /* __iketypes_h__ */

This is a bug in the mingw header files. You need a patch for it (or upgrade to a newer version than contained in ubuntu). Annoying indeed.

Quoted 6 lines

In file included from /usr/share/mingw-w64/include/fwpmu.h:10:0,

                 from win32.c:52:
/usr/share/mingw-w64/include/fwpmtypes.h:54:3: error: conflicting types for 
???FWPM_DISPLAY_DATA0???
 } FWPM_DISPLAY_DATA0;
   ^

Same thing: buggy header files that do not properly protect against multi-inclusion.

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#4 lore raw
In reply to [email protected]...
Quoted 3 lines · On Tue, Dec 15, 2015 at 11:29 AM, <[email protected]...> wrote:

Any clarity on what to expect of the --block-outside-dns option and what windows version it is/will be support would help.

1. git_master:
- May be built with target = vista and will run correctly only on vista
and above
(this is the default target in openvpn-build if git-master source is
used)
- Will support --block-outside-dns when run on vista and above --
undefined behaviour if attempted to run on winxp

2. release/2.3 (and upcoming 2.3.9)
- May be built for target = winxp
(this is the default target in openvpn-build if release/2.3 source is
used)
- Support for --block-outside-dns determined automatically at run-time:
when run on vista and above the option will be supported when run on winxp the option will be ignored or cause
a fatal error depending on how it is specified:
if pushed from a server: just a warning in the logs specified in the config: fatal error unless protected by ignore-unknown-option or setenv-opt or forward-compatible...

3. Both should build correctly for 64-bit and 32-bit platforms

Selva

#3 lore raw
In reply to Gert Doering

----- Original Message ----- From: "Gert Doering" <[email protected]...>
To: <[email protected]...>
Cc: <[email protected]>
Sent: Tuesday, December 15, 2015 5:10 PM
Subject: Re: [Openvpn-devel] [PATCH] Updates to Changes.rst

Quoted 3 lines

This is a bug in the mingw header files. You need a patch for it (or upgrade to a newer version than contained in ubuntu). Annoying indeed.

<..>

Quoted 2 lines

Same thing: buggy header files that do not properly protect against multi-inclusion.

Ahh .. OK I had a feeling it was going to be something unexpected :-)

Re: 2.3branch vs git-master .. thanks still have a lot to learn ...

Thanks very much Gert and Selva.

#5 lore raw
In reply to Selva Nair

Hi,

Quoted 7 lines · Selva Nair

1. git_master:
- May be built with target = vista and will run correctly only on vista
and above
(this is the default target in openvpn-build if git-master source is
used)
- Will support --block-outside-dns when run on vista and above --
undefined behaviour if attempted to run on winxp

I'm fairly sure the binary will not start at all. It's calling symbols that are not *there*, so the dll linker will just refuse to run it.

Quoted 11 lines

2. release/2.3 (and upcoming 2.3.9)
- May be built for target = winxp
(this is the default target in openvpn-build if release/2.3 source is
used)
- Support for --block-outside-dns determined automatically at run-time:
when run on vista and above the option will be supported when run on winxp the option will be ignored or cause
a fatal error depending on how it is specified:
if pushed from a server: just a warning in the logs specified in the config: fatal error unless protected by ignore-unknown-option or setenv-opt or forward-compatible...

Make that "setenv opt block-outside-dns". ignore-unknown-option will *not* help here, as it is not "unknown", but just "not working".

Quoted 1 line

3. Both should build correctly for 64-bit and 32-bit platforms

Yep.

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#6 lore raw

Hi,

Quoted 16 lines · Gert Doering

Hi,

Quoted 11 lines · Selva Nair

2. release/2.3 (and upcoming 2.3.9)
- May be built for target = winxp
(this is the default target in openvpn-build if release/2.3 source is
used)
- Support for --block-outside-dns determined automatically at run-time:
when run on vista and above the option will be supported when run on winxp the option will be ignored or cause
a fatal error depending on how it is specified:
if pushed from a server: just a warning in the logs specified in the config: fatal error unless protected by ignore-unknown-option or setenv-opt or forward-compatible...

Quoted 3 lines

Make that "setenv opt block-outside-dns". ignore-unknown-option will *not* help here, as it is not "unknown", but just "not working".

You are right, ignore-unknown .. would have worked with valdikSS patch, but not any more as its handled right away at msglevel_fc. Which is a bit disconcerting as on non-windows platforms ignore-unknown-option will make it non-FATAL but not on XP.

My original comment about this to an early version of valdikSS' patch was on a different level -- if the user want DNS blocked, failure to block should be FATAL. But not respecting ignore-unknown-option only on some platforms doesn't look right.

Selva

#7 lore raw

Hi,

Quoted 7 lines · Selva Nair
Quoted 2 lines

Make that "setenv opt block-outside-dns". ignore-unknown-option will *not* help here, as it is not "unknown", but just "not working".

You are right, ignore-unknown .. would have worked with valdikSS patch, but not any more as its handled right away at msglevel_fc. Which is a bit disconcerting as on non-windows platforms ignore-unknown-option will make it non-FATAL but not on XP.

Right. So, just use "setenv opt" always here, and don't worry any longer :)

Quoted 4 lines

My original comment about this to an early version of valdikSS' patch was on a different level -- if the user want DNS blocked, failure to block should be FATAL. But not respecting ignore-unknown-option only on some platforms doesn't look right.

Well, it is not an "unknown option" on XP... and the code doesn't really lend itself to "just claim it's an unknown option if it cannot be enabled" without being truly ugly...

(setenv opt wouldn't make it non-fatal if the functionality is *there* but cannot be enabled for whatever reason - so on Vista+, you still have the "failure to block is FATAL")

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...
#8 lore raw

Hi,

Quoted 10 lines
Quoted 2 lines

My original comment about this to an early version of valdikSS' patch was on a different level -- if the user want DNS blocked, failure to

block

Quoted 2 lines

should be FATAL. But not respecting ignore-unknown-option only on some platforms doesn't look right.

Well, it is not an "unknown option" on XP... and the code doesn't really lend itself to "just claim it's an unknown option if it cannot be enabled" without being truly ugly...

Well,
else if (streq (p[0], "block-outside-dns") && !p[1] && win_wfp_init_funcs()) {..
}
will do it, but then one can't print a helpful error for the XP folks. The current
"die with a nice mssage" is probbaly better ..

Sorry, I know I'm supposed to stop worrying about it :)

Selva

#9 lore raw

Hi,

Quoted 9 lines · Selva Nair
Quoted 3 lines

Well, it is not an "unknown option" on XP... and the code doesn't really lend itself to "just claim it's an unknown option if it cannot be enabled" without being truly ugly...

Well,
else if (streq (p[0], "block-outside-dns") && !p[1] && win_wfp_init_funcs()) {..
}
will do it, but then one can't print a helpful error for the XP folks.

Thinking about it again, we could indeed print the "helpful error for XP" inside win_wfp_init_funcs(), and then use the code the way you propose (and it's less ugly than I feared).

But it will still be confusing then, to see a message about "cannot load WFP modules!" and, after that, "unknown option!"...

For 2.3.9, let's just leave it as it is and get it *out*. Revisit later, if sufficient user confusion is detected :-)

gert

Signature · 4 lines
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             [email protected]...
fax: +49-89-35655025                        [email protected]...